Paths

Table of Contentst

Differential D8256

[keyserver] Upload both multimedia holder and blob_hash
ClosedPublic
Actions

Authored by bartek on Jun 20 2023, 5:16 AM.

Tags

None

Referenced Files

	Unknown Object (File)
	Wed, Jan 1, 4:20 AM

	Unknown Object (File)
	Wed, Jan 1, 4:20 AM

	Unknown Object (File)
	Wed, Jan 1, 4:20 AM

	Unknown Object (File)
	Wed, Jan 1, 4:20 AM

	Unknown Object (File)
	Wed, Jan 1, 4:16 AM

	Unknown Object (File)
	Mon, Dec 16, 6:03 AM

	Unknown Object (File)
	Nov 23 2024, 1:05 PM

	Unknown Object (File)
	Nov 23 2024, 1:05 PM

Subscribers

Details

Reviewers

atul
ashoat

Commits

rCOMMeb27060339c0: [keyserver] Upload both multimedia holder and blob_hash

Summary

Resolves ENG-3962 and its subtasks. It turned out to be a one-line change on client side.
Basically, added a blobHash field to endpoint input types and passed it all the way down input-state-container -> uploadMediaMetadata endpoint -> createUploads() -> db

Test Plan

Enabled blob service uploads on web and uploaded a photo. Checked in TablePlus that both values are stored on the keyserver. Repeated for native.

Diff Detail

Repository

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

bartek created this revision.Jun 20 2023, 5:16 AM

bartek held this revision as a draft.

Herald added a subscriber: tomek. · View Herald TranscriptJun 20 2023, 5:16 AM

bartek added a child revision: D8257: [keyserver] Return blob hash and holder from upload endpoint.Jun 20 2023, 5:20 AM

bartek published this revision for review.Jun 20 2023, 5:33 AM

Harbormaster completed remote builds in B20342: Diff 27883.Jun 20 2023, 5:34 AM

ashoat accepted this revision.Jun 20 2023, 5:56 AM

This revision is now accepted and ready to land.Jun 20 2023, 5:56 AM

bartek added a child revision: D8320: [web] Use local holder for blob deletion.Jun 26 2023, 9:03 PM

Rebase

Harbormaster completed remote builds in B20586: Diff 28223.Jun 28 2023, 1:34 PM

Closed by commit rCOMMeb27060339c0: [keyserver] Upload both multimedia holder and blob_hash (authored by bartek). · Explain WhyJun 28 2023, 11:12 PM

This revision was automatically updated to reflect the committed changes.

bartek added a commit: rCOMMeb27060339c0: [keyserver] Upload both multimedia holder and blob_hash.

Revision Contents
Changeset List

Path

Size

keyserver/

src/

creators/

upload-creator.js

7 lines

uploads/

15 lines

lib/

types/

1 line

native/

input/

input-state-container.react.js

1 line

web/

input/

input-state-container.react.js

1 line

Diff 28223

keyserver/src/creators/upload-creator.js

Loading...

keyserver/src/uploads/uploads.js

Loading...

lib/types/media-types.js

Loading...

native/input/input-state-container.react.js

Loading...

web/input/input-state-container.react.js

Loading...