Page MenuHomePhabricator
Differential D8320

[web] Use local holder for blob deletion
ClosedPublic
Actions

Authored by bartek on Jun 26 2023, 9:03 PM.
Tags
None
Referenced Files
Unknown Object (File)
Nov 23 2024, 1:15 PM
Unknown Object (File)
Nov 23 2024, 1:15 PM
Unknown Object (File)
Nov 23 2024, 1:14 PM
Unknown Object (File)
Nov 23 2024, 1:14 PM
Unknown Object (File)
Nov 17 2024, 8:21 AM
Unknown Object (File)
Nov 10 2024, 12:33 PM
Unknown Object (File)
Nov 9 2024, 4:19 AM
Unknown Object (File)
Nov 8 2024, 8:03 AM
View All Files
Subscribers
tomek

Details

Reviewers
atul
ashoat
Commits
rCOMM9310a1ad5108: [web] Use local holder for blob deletion
Summary

Replaces D8257 - on web, a newly-created blob holder needs to be kept to be able to delete the blob, when a user cancels sending a media while it is already uploaded

Depends on D8256

Test Plan

Enabled blob service uploads, selected a photo to send. Ensured the blob was uploaded successfully. Then clicked the cross button to unselect the photo. Ensured the blob was deleted

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

bartek created this revision.Jun 26 2023, 9:03 PM
bartek held this revision as a draft.
Herald added a subscriber: tomek. · View Herald TranscriptJun 26 2023, 9:03 PM
bartek added a child revision: D8321: [keyserver] Use blob hash to create blob URIs.Jun 26 2023, 9:04 PM
Harbormaster completed remote builds in B20515: Diff 28129.Jun 26 2023, 9:22 PM
bartek edited the summary of this revision. (Show Details)Jun 26 2023, 11:08 PM
bartek edited the test plan for this revision. (Show Details)
bartek published this revision for review.Jun 26 2023, 11:11 PM
bartek added inline comments.
web/input/input-state-container.react.js
1080 ↗(On Diff #28129)

This void was incorrect previously. It should initially be UploadMultimediaResult.

bartek mentioned this in D8257: [keyserver] Return blob hash and holder from upload endpoint.Jun 26 2023, 11:14 PM
atul accepted this revision.Jun 28 2023, 11:09 AM
This revision is now accepted and ready to land.Jun 28 2023, 11:09 AM
bartek updated this revision to Diff 28224.Jun 28 2023, 1:14 PM
bartek edited the summary of this revision. (Show Details)

Rebase

Harbormaster completed remote builds in B20587: Diff 28224.Jun 28 2023, 1:33 PM
Closed by commit rCOMM9310a1ad5108: [web] Use local holder for blob deletion (authored by bartek). · Explain WhyJun 28 2023, 11:12 PM
This revision was automatically updated to reflect the committed changes.
bartek added a commit: rCOMM9310a1ad5108: [web] Use local holder for blob deletion.

Revision Contents
Changeset List

PathSize
web/
input/
23 lines
1 line

Diff 28242

View Options

web/input/input-state-container.react.js

Loading...
View Options

web/input/input-state.js

Loading...