Page MenuHomePhabricator
Differential D8410

[native] switch getViewerAlreadySelectedMessageReactions to useGetViewerAlreadySelectedMessageReactions
ClosedPublic
Actions

Authored by ginsu on Jul 3 2023, 1:25 AM.
Tags
None
Referenced Files
F2904457: D8410.diff
Sun, Oct 6, 1:18 AM
Unknown Object (File)
Fri, Oct 4, 3:37 AM
Unknown Object (File)
Thu, Oct 3, 1:49 AM
Unknown Object (File)
Thu, Oct 3, 1:49 AM
Unknown Object (File)
Thu, Oct 3, 1:49 AM
Unknown Object (File)
Thu, Oct 3, 1:48 AM
Unknown Object (File)
Thu, Oct 3, 1:44 AM
Unknown Object (File)
Mon, Sep 23, 3:57 AM
View All Files
Subscribers
ashoat
tomek

Details

Reviewers
atul
kamil
Commits
rCOMM864aeee11a51: [native] switch getViewerAlreadySelectedMessageReactions to…
Summary

small follow up diff to address comment in D8288

Test Plan

confirmed that the already selected emojis still behaved as expected in the emoji keyboard

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

ginsu created this revision.Jul 3 2023, 1:25 AM
Herald added subscribers: tomek, ashoat. · View Herald TranscriptJul 3 2023, 1:25 AM
ginsu mentioned this in D8288: [lib/native] introduce getViewerAlreadySelectedMessageReactions.Jul 3 2023, 1:26 AM
ginsu added reviewers: atul, kamil.
Harbormaster completed remote builds in B20675: Diff 28333.Jul 3 2023, 1:44 AM
ginsu requested review of this revision.Jul 3 2023, 1:44 AM
kamil accepted this revision.Jul 3 2023, 9:01 AM

Thanks for addressing this, I should've caught this on the first review round

lib/shared/reaction-utils.js
36

I think this is more suitable, get prefix seems more function-like, not hook

This revision is now accepted and ready to land.Jul 3 2023, 9:01 AM
ashoat added inline comments.Jul 3 2023, 10:41 AM
lib/shared/reaction-utils.js
36

Agree

ginsu updated this revision to Diff 28425.Jul 5 2023, 1:47 PM

address comments

This revision was landed with ongoing or failed builds.Jul 5 2023, 1:48 PM
Closed by commit rCOMM864aeee11a51: [native] switch getViewerAlreadySelectedMessageReactions to… (authored by ginsu). · Explain Why
This revision was automatically updated to reflect the committed changes.
ginsu added a commit: rCOMM864aeee11a51: [native] switch getViewerAlreadySelectedMessageReactions to….
Harbormaster completed remote builds in B20750: Diff 28425.Jul 5 2023, 2:07 PM

Revision Contents
Changeset List

Diff 28333

View Options

lib/shared/reaction-utils.js

Loading...
View Options

native/chat/multimedia-message-tooltip-button.react.js

Loading...
View Options

native/chat/robotext-message-tooltip-button.react.js

Loading...
View Options

native/chat/text-message-tooltip-button.react.js

Loading...