[native] default selectMultipleEmojis to false for emoji keyboard
ClosedPublic
Actions

Authored by ginsu on Jun 26 2023, 4:08 PM.

Details

Reviewers

atul
kamil

Commits

rCOMMd738d9261ff9: [native] default selectMultipleEmojis to false for emoji keyboard

Summary

As I was working on the inline engagement redesign, I noticed some strange behavior with the emoji keyboard showing the already selected emoji when selecting a new emoji. This diff fixes that issue

Test Plan

Emoji keyboard now works as expected

Diff Detail

Repository

rCOMM Comm

Branch

arcpatch-D8319 (branched from master)

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

ginsu created this revision.Jun 26 2023, 4:08 PM

Herald added subscribers: tomek, ashoat. · View Herald TranscriptJun 26 2023, 4:08 PM

ginsu edited the summary of this revision. (Show Details)Jun 26 2023, 4:15 PM

ginsu edited the test plan for this revision. (Show Details)

ginsu added reviewers: atul, kamil.

ginsu published this revision for review.Jun 26 2023, 4:18 PM

ginsu attached a referenced file: F608305: Screen Recording 2023-06-26 at 4.08.15 PM.mov. (Show Details)

ginsu added inline comments.

native/components/emoji-keyboard.react.js
79 ↗	(On Diff #28126)	The issue was I was entering this case, since I wasn't passing in `selectMultipleEmojis` to the `EmojiKeyboard` components above smh