Page MenuHomePhabricator
Differential D8587

[Keyserver/rust] Improve debugging
ClosedPublic
Actions

Authored by • jon on Jul 20 2023, 9:25 AM.
Tags
None
Referenced Files
F3384611: D8587.id28895.diff
Thu, Nov 28, 9:50 PM
F3384330: D8587.id29020.diff
Thu, Nov 28, 8:32 PM
F3383970: D8587.diff
Thu, Nov 28, 6:38 PM
Unknown Object (File)
Sat, Nov 23, 12:53 PM
Unknown Object (File)
Tue, Nov 19, 5:54 AM
Unknown Object (File)
Tue, Nov 19, 5:54 AM
Unknown Object (File)
Tue, Nov 19, 5:54 AM
Unknown Object (File)
Tue, Nov 19, 5:54 AM
View All 78 Files
Subscribers
ashoat
tomek

Details

Reviewers
bartek
varun
Commits
rCOMM1b51382d1050: [Keyserver/rust] Improve debugging
Summary

This was useful in helping track down
https://linear.app/comm/issue/ENG-4418. Would like to see these changes
persisted so if errors do arise in the future, we get more than nothing

Test Plan
cd keyserver
RUST_LOG=debug yarn dev

Diff Detail

Repository
rCOMM Comm
Branch
jonringer/keyserver-rust-debug
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

• jon created this revision.Jul 20 2023, 9:25 AM
Herald added subscribers: tomek, ashoat. · View Herald TranscriptJul 20 2023, 9:25 AM
Harbormaster completed remote builds in B21090: Diff 28895.Jul 20 2023, 9:43 AM
• jon requested review of this revision.Jul 20 2023, 9:43 AM
bartek accepted this revision.Jul 20 2023, 9:58 AM
This revision is now accepted and ready to land.Jul 20 2023, 9:58 AM
Closed by commit rCOMM1b51382d1050: [Keyserver/rust] Improve debugging (authored by • jon). · Explain WhyJul 25 2023, 6:24 AM
This revision was automatically updated to reflect the committed changes.
• jon added a commit: rCOMM1b51382d1050: [Keyserver/rust] Improve debugging.
ashoat added inline comments.Jul 27 2023, 1:51 PM
keyserver/src/user/login.js
175 ↗(On Diff #29020)

For future reference, Node generally does a better job coercing things into strings than getMessageForException

Revision Contents
Changeset List

PathSize
keyserver/
addons/
rust-node-addon/
src/
identity_client/
8 lines
src/
user/
1 line

Diff 28895

View Options

keyserver/addons/rust-node-addon/src/identity_client/login.rs

Loading...
View Options

keyserver/src/user/login.js

Loading...