Paths

Table of Contentst

Differential D8615

[keyserver][lib] Block users from creating reserved invite links
ClosedPublic
Actions

Authored by tomek on Jul 25 2023, 3:39 AM.

Tags

None

Referenced Files

	F2785761: D8615.id29177.diff
	Fri, Sep 20, 8:20 PM

	F2783998: D8615.diff
	Fri, Sep 20, 6:13 PM

	F2773164: D8615.id29177.diff
	Fri, Sep 20, 1:55 AM

	F2773163: D8615.id29173.diff
	Fri, Sep 20, 1:55 AM

	F2773161: D8615.id29011.diff
	Fri, Sep 20, 1:55 AM

	Unknown Object (File)
	Sun, Sep 15, 4:13 PM

	Unknown Object (File)
	Mon, Sep 9, 12:07 AM

	Unknown Object (File)
	Fri, Sep 6, 10:05 PM

View All 92 Files

Subscribers

None

Details

Reviewers

kamil
inka
ashoat

Commits

rCOMM4ba08e6df607: [keyserver][lib] Block users from creating reserved invite links

Summary

A user should not be able to create a link which is included in a list of reserved usernames. The copy is similar to a message that is shown when a user tries to create an account with reserved username: /native/account/registration/registration-server-call.js, but I'm not sure if we should mention support email (the user is already registered and can contact us on Comm).

Depends on D8527

Test Plan

Try to create /comm invite link - a message should be displayed.

Diff Detail

Repository

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

tomek created this revision.Jul 25 2023, 3:39 AM

Harbormaster completed remote builds in B21178: Diff 29011.Jul 25 2023, 4:27 AM

tomek requested review of this revision.Jul 25 2023, 4:27 AM

inka accepted this revision.Jul 26 2023, 1:36 AM

This revision is now accepted and ready to land.Jul 26 2023, 1:36 AM

ashoat added inline comments.Jul 27 2023, 6:14 PM

lib/shared/invite-links.js
8–9	It's a little inconsistent how we're using full sentences here, but not in the other ones. Should we add a period to the other ones?

tomek added inline comments.Jul 28 2023, 6:30 AM

lib/shared/invite-links.js
8–9	It is probably a good idea - going to update the original diff

Rebase

Harbormaster failed remote builds in B21302: Diff 29173!Jul 28 2023, 8:06 AM

Harbormaster completed remote builds in B21302: Diff 29173.Jul 28 2023, 8:19 AM

Closed by commit rCOMM4ba08e6df607: [keyserver][lib] Block users from creating reserved invite links (authored by tomek). · Explain WhyJul 28 2023, 8:20 AM

This revision was automatically updated to reflect the committed changes.

tomek added a commit: rCOMM4ba08e6df607: [keyserver][lib] Block users from creating reserved invite links.

Revision Contents
Changeset List

Path

Size

keyserver/

src/

creators/

invite-link-creator.js

4 lines

lib/

shared/

invite-links.js

5 lines

Diff 29011

keyserver/src/creators/invite-link-creator.js

Loading...

lib/shared/invite-links.js

Loading...