Page MenuHomePhabricator
Differential D8599

[native] upgrade rn-emoji-keyboard to v1.5.0
ClosedPublic
Actions

Authored by ginsu on Jul 21 2023, 11:01 AM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Sep 27, 4:16 PM
Unknown Object (File)
Thu, Sep 26, 6:55 PM
Unknown Object (File)
Fri, Sep 20, 8:33 PM
Unknown Object (File)
Fri, Sep 20, 8:33 PM
Unknown Object (File)
Fri, Sep 20, 8:33 PM
Unknown Object (File)
Fri, Sep 20, 1:55 AM
Unknown Object (File)
Fri, Sep 20, 1:55 AM
Unknown Object (File)
Fri, Sep 20, 1:55 AM
View All Files
Subscribers
ashoat
tomek

Details

Reviewers
atul
kamil
ashoat
Commits
rCOMM41939d6ed964: [native] upgrade rn-emoji-keyboard to v1.5.0
Summary

Our friends from rn-emoji-keyboard just released a new update to their emoji keyboard library which includes a new and improved search. This diff updates our usage of rn-emoji-keyboard to this new version

Link to update announcement: https://twitter.com/k7grzywacz/status/1682106194536669184?s=20

Test Plan

Check out the demo videos below to see the improved search in the native emoji keyboard:

Before:

After:

Diff Detail

Repository
rCOMM Comm
Branch
emoji-keyboard-upgrade (branched from master)
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

ginsu created this revision.Jul 21 2023, 11:01 AM
Herald added subscribers: tomek, ashoat. · View Herald TranscriptJul 21 2023, 11:01 AM
ginsu edited the summary of this revision. (Show Details)Jul 21 2023, 11:15 AM
ginsu edited the test plan for this revision. (Show Details)
ginsu added reviewers: atul, kamil, ashoat.
ginsu attached a referenced file: F648560: Screen Recording 2023-07-21 at 2.08.32 PM.mov. (Show Details)
ginsu attached a referenced file: F648559: Screen Recording 2023-07-21 at 2.13.49 PM.mov. (Show Details)

Made @ashoat blocking since this a dependency diff

Harbormaster completed remote builds in B21128: Diff 28950.Jul 21 2023, 11:19 AM
ginsu requested review of this revision.Jul 21 2023, 11:19 AM
atul accepted this revision.Jul 23 2023, 1:17 PM
kamil accepted this revision.Jul 24 2023, 1:58 AM
ashoat accepted this revision.Jul 27 2023, 1:13 PM
This revision is now accepted and ready to land.Jul 27 2023, 1:13 PM
ginsu updated this revision to Diff 29147.Jul 27 2023, 1:27 PM
ginsu edited the test plan for this revision. (Show Details)

rebase before landing

This revision was landed with ongoing or failed builds.Jul 27 2023, 1:28 PM
Closed by commit rCOMM41939d6ed964: [native] upgrade rn-emoji-keyboard to v1.5.0 (authored by ginsu). · Explain Why
This revision was automatically updated to reflect the committed changes.
ginsu added a commit: rCOMM41939d6ed964: [native] upgrade rn-emoji-keyboard to v1.5.0.
Harbormaster completed remote builds in B21285: Diff 29147.Jul 27 2023, 1:44 PM

Revision Contents
Changeset List

PathSize
native/
2 lines
8 lines

Diff 29147

View Options

native/package.json

Loading...
View Options

yarn.lock

Loading...