Page MenuHomePhabricator

[keyserver][lib] Block users from creating reserved invite links
ClosedPublic

Authored by tomek on Jul 25 2023, 3:39 AM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Oct 22, 2:29 PM
Unknown Object (File)
Tue, Oct 22, 2:29 PM
Unknown Object (File)
Tue, Oct 22, 2:29 PM
Unknown Object (File)
Tue, Oct 22, 2:28 PM
Unknown Object (File)
Tue, Oct 22, 5:03 AM
Unknown Object (File)
Oct 7 2024, 9:41 AM
Unknown Object (File)
Oct 7 2024, 9:41 AM
Unknown Object (File)
Sep 28 2024, 7:30 PM
Subscribers
None

Details

Summary

A user should not be able to create a link which is included in a list of reserved usernames. The copy is similar to a message that is shown when a user tries to create an account with reserved username: /native/account/registration/registration-server-call.js, but I'm not sure if we should mention support email (the user is already registered and can contact us on Comm).

Depends on D8527

Test Plan

Try to create /comm invite link - a message should be displayed.

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

tomek requested review of this revision.Jul 25 2023, 4:27 AM
This revision is now accepted and ready to land.Jul 26 2023, 1:36 AM
lib/shared/invite-links.js
8–9 ↗(On Diff #29011)

It's a little inconsistent how we're using full sentences here, but not in the other ones. Should we add a period to the other ones?

lib/shared/invite-links.js
8–9 ↗(On Diff #29011)

It is probably a good idea - going to update the original diff