Page MenuHomePhabricator
Differential D8670

[web] refactor processing store operations on worker
ClosedPublic
Actions

Authored by kamil on Jul 31 2023, 2:27 AM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Apr 8, 3:27 PM
Unknown Object (File)
Thu, Apr 3, 10:46 PM
Unknown Object (File)
Tue, Apr 1, 9:56 PM
Unknown Object (File)
Tue, Mar 25, 4:46 PM
Unknown Object (File)
Mon, Mar 24, 2:11 PM
Unknown Object (File)
Mon, Mar 24, 2:11 PM
Unknown Object (File)
Sun, Mar 23, 1:38 PM
Unknown Object (File)
Sat, Mar 22, 3:40 PM
View All Files
Subscribers
ashoat

Details

Reviewers
michal
tomek
Commits
rCOMM1af81091dfc5: [web] refactor processing store operations on worker
Summary

This addresses: https://phab.comm.dev/D8612#253783.

Test Plan

Check if operations on web works.

Diff Detail

Repository
rCOMM Comm
Branch
db-worker-cleanup
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

kamil created this revision.Jul 31 2023, 2:27 AM
kamil held this revision as a draft.
Herald added a subscriber: ashoat. · View Herald TranscriptJul 31 2023, 2:27 AM
kamil added inline comments.Jul 31 2023, 2:28 AM
web/database/worker/db-worker.js
194

Flow forces to use it second time in this function

kamil published this revision for review.Jul 31 2023, 2:37 AM
Harbormaster completed remote builds in B21356: Diff 29256.Jul 31 2023, 2:44 AM
tomek accepted this revision.Jul 31 2023, 4:35 AM
This revision is now accepted and ready to land.Jul 31 2023, 4:35 AM
Closed by commit rCOMM1af81091dfc5: [web] refactor processing store operations on worker (authored by kamil). · Explain WhyAug 1 2023, 3:16 AM
This revision was automatically updated to reflect the committed changes.
kamil added a commit: rCOMM1af81091dfc5: [web] refactor processing store operations on worker.

Revision Contents
Changeset List

PathSize
web/
database/
worker/
88 lines
79 lines

Diff 29256

View Options

web/database/worker/db-worker.js

// @flow // @flow
import { setClientDBStoreActionType } from '../actions/client-db-store-actions.js'; import { setClientDBStoreActionType } from '../actions/client-db-store-actions.js';
import { addCommunityActionType } from '../actions/community-actions.js'; import {
addCommunityActionType,
fetchCommunityInfosActionTypes,
createOrUpdateFarcasterChannelTagActionTypes,
deleteFarcasterChannelTagActionTypes,
} from '../actions/community-actions.js';
import { import {
communityStoreOpsHandlers, communityStoreOpsHandlers,
type CommunityStoreOperation, type CommunityStoreOperation,
type ReplaceCommunityOperation, type ReplaceCommunityOperation,
} from '../ops/community-store-ops.js'; } from '../ops/community-store-ops.js';
import type { CommunityStore } from '../types/community-types.js'; import type { CommunityStore } from '../types/community-types.js';
import type { BaseAction } from '../types/redux-types'; import type { BaseAction } from '../types/redux-types';
const { processStoreOperations: processStoreOps } = communityStoreOpsHandlers; const { processStoreOperations: processStoreOps } = communityStoreOpsHandlers;
function reduceCommunityStore( function reduceCommunityStore(
state: CommunityStore, state: CommunityStore,
action: BaseAction, action: BaseAction,
): { ): {
+communityStore: CommunityStore, +communityStore: CommunityStore,
+communityStoreOperations: $ReadOnlyArray<CommunityStoreOperation>, +communityStoreOperations: $ReadOnlyArray<CommunityStoreOperation>,
} { } {
if (action.type === addCommunityActionType) { if (action.type === fetchCommunityInfosActionTypes.success) {
const replaceOperations = action.payload.communityInfos.map(community => {
const { id, ...communityInfo } = community;
return {
type: 'replace_community',
payload: {
id,
communityInfo,
},
};
});
return {
communityStore: processStoreOps(state, replaceOperations),
communityStoreOperations: replaceOperations,
};
} else if (
action.type === createOrUpdateFarcasterChannelTagActionTypes.success
) {
const communityID = action.payload.commCommunityID;
const replaceOperation: ReplaceCommunityOperation = {
type: 'replace_community',
payload: {
id: communityID,
communityInfo: {
...state.communityInfos[communityID],
farcasterChannelID: action.payload.farcasterChannelID,
},
},
};
return {
communityStore: processStoreOps(state, [replaceOperation]),
communityStoreOperations: [replaceOperation],
};
} else if (action.type === deleteFarcasterChannelTagActionTypes.success) {
const communityID = action.payload.commCommunityID;
const replaceOperation: ReplaceCommunityOperation = {
type: 'replace_community',
payload: {
id: communityID,
communityInfo: {
...state.communityInfos[communityID],
farcasterChannelID: null,
},
},
};
return {
communityStore: processStoreOps(state, [replaceOperation]),
communityStoreOperations: [replaceOperation],
};
} else if (action.type === addCommunityActionType) {
const replaceOperation: ReplaceCommunityOperation = { const replaceOperation: ReplaceCommunityOperation = {
type: 'replace_community', type: 'replace_community',
payload: { payload: {
id: action.payload.id, id: action.payload.id,
communityInfo: action.payload.newCommunityInfo, communityInfo: action.payload.newCommunityInfo,
}, },
}; };
Show All 32 Lines
View Options

web/database/worker/process-operations.js

// @flow // @flow
import { setClientDBStoreActionType } from '../actions/client-db-store-actions.js'; import { setClientDBStoreActionType } from '../actions/client-db-store-actions.js';
import { addCommunityActionType } from '../actions/community-actions.js'; import {
addCommunityActionType,
fetchCommunityInfosActionTypes,
createOrUpdateFarcasterChannelTagActionTypes,
deleteFarcasterChannelTagActionTypes,
} from '../actions/community-actions.js';
import { import {
communityStoreOpsHandlers, communityStoreOpsHandlers,
type CommunityStoreOperation, type CommunityStoreOperation,
type ReplaceCommunityOperation, type ReplaceCommunityOperation,
} from '../ops/community-store-ops.js'; } from '../ops/community-store-ops.js';
import type { CommunityStore } from '../types/community-types.js'; import type { CommunityStore } from '../types/community-types.js';
import type { BaseAction } from '../types/redux-types'; import type { BaseAction } from '../types/redux-types';
const { processStoreOperations: processStoreOps } = communityStoreOpsHandlers; const { processStoreOperations: processStoreOps } = communityStoreOpsHandlers;
function reduceCommunityStore( function reduceCommunityStore(
state: CommunityStore, state: CommunityStore,
action: BaseAction, action: BaseAction,
): { ): {
+communityStore: CommunityStore, +communityStore: CommunityStore,
+communityStoreOperations: $ReadOnlyArray<CommunityStoreOperation>, +communityStoreOperations: $ReadOnlyArray<CommunityStoreOperation>,
} { } {
if (action.type === addCommunityActionType) { if (action.type === fetchCommunityInfosActionTypes.success) {
const replaceOperations = action.payload.communityInfos.map(community => {
const { id, ...communityInfo } = community;
return {
type: 'replace_community',
payload: {
id,
communityInfo,
},
};
});
return {
communityStore: processStoreOps(state, replaceOperations),
communityStoreOperations: replaceOperations,
};
} else if (
action.type === createOrUpdateFarcasterChannelTagActionTypes.success
) {
const communityID = action.payload.commCommunityID;
const replaceOperation: ReplaceCommunityOperation = {
type: 'replace_community',
payload: {
id: communityID,
communityInfo: {
...state.communityInfos[communityID],
farcasterChannelID: action.payload.farcasterChannelID,
},
},
};
return {
communityStore: processStoreOps(state, [replaceOperation]),
communityStoreOperations: [replaceOperation],
};
} else if (action.type === deleteFarcasterChannelTagActionTypes.success) {
const communityID = action.payload.commCommunityID;
const replaceOperation: ReplaceCommunityOperation = {
type: 'replace_community',
payload: {
id: communityID,
communityInfo: {
...state.communityInfos[communityID],
farcasterChannelID: null,
},
},
};
return {
communityStore: processStoreOps(state, [replaceOperation]),
communityStoreOperations: [replaceOperation],
};
} else if (action.type === addCommunityActionType) {
const replaceOperation: ReplaceCommunityOperation = { const replaceOperation: ReplaceCommunityOperation = {
type: 'replace_community', type: 'replace_community',
payload: { payload: {
id: action.payload.id, id: action.payload.id,
communityInfo: action.payload.newCommunityInfo, communityInfo: action.payload.newCommunityInfo,
}, },
}; };
Show All 32 Lines