Page MenuHomePhabricator
Differential D8700

[keyserver] await INSERT INTO messages before calling postMessageSend
ClosedPublic
Actions

Authored by ashoat on Aug 1 2023, 10:29 AM.
Tags
None
Referenced Files
F3246556: D8700.diff
Fri, Nov 15, 12:38 AM
Unknown Object (File)
Wed, Nov 13, 12:34 AM
Unknown Object (File)
Fri, Nov 1, 8:58 AM
Unknown Object (File)
Fri, Nov 1, 8:58 AM
Unknown Object (File)
Fri, Nov 1, 8:55 AM
Unknown Object (File)
Fri, Nov 1, 4:09 AM
Unknown Object (File)
Sun, Oct 20, 9:02 PM
Unknown Object (File)
Oct 10 2024, 1:13 PM
View All 93 Files
Subscribers
None

Details

Reviewers
kamil
michal
atul
tomek
Commits
rCOMMf58ed7ac8353: [keyserver] await INSERT INTO messages before calling postMessageSend
Summary

We want to check if there is a collision on the INSERT before calling postMessageSend in order to avoid creating duplicate notifs or UpdateInfos.

See ENG-4563 for more details.

Test Plan

I tested message creation to make sure it still works

Diff Detail

Repository
rCOMM Comm
Branch
ashoat/doublemessage
Lint
No Lint Coverage
Unit
No Test Coverage

Revision Contents
Changeset List

PathSize
keyserver/
src/
creators/
3 lines

Diff 29453

View Options

keyserver/src/creators/message-creator.js

Loading...