Page MenuHomePhabricator
Differential D8645

[lib, web] Use sessionId from keyserverStore
ClosedPublic
Actions

Authored by inka on Jul 27 2023, 8:16 AM.
Tags
None
Referenced Files
F3386409: D8645.diff
Fri, Nov 29, 4:34 AM
Unknown Object (File)
Sat, Nov 23, 9:54 AM
Unknown Object (File)
Fri, Nov 1, 7:37 AM
Unknown Object (File)
Oct 11 2024, 10:30 PM
Unknown Object (File)
Oct 9 2024, 3:31 PM
Unknown Object (File)
Oct 5 2024, 6:25 AM
Unknown Object (File)
Oct 4 2024, 9:24 PM
Unknown Object (File)
Oct 4 2024, 8:15 AM
View All 92 Files
Subscribers
ashoat
tomek

Details

Reviewers
michal
kamil
Commits
rCOMM01332e50f17b: [lib, web] Use sessionId from keyserverStore
Summary

issue: https://linear.app/comm/issue/ENG-4457/refactor-sessionid-field
Start reducing sessionID in keyserverStore and using it in places where we were using sessionID redux field.

Test Plan

Ran yarn flow-all. Checked that sessionID field in keyserverStore has the same value as sessionID redux field when user loges out,
logs in.

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

inka created this revision.Jul 27 2023, 8:16 AM
Herald added subscribers: tomek, ashoat. · View Herald TranscriptJul 27 2023, 8:16 AM
inka added a parent revision: D8644: [lib, web, natvie] Add sessionID field to keyserverStore.Jul 27 2023, 8:20 AM
inka added a child revision: D8646: [lib][web][native] Remove sessionID redux field.
Harbormaster completed remote builds in B21277: Diff 29139.Jul 27 2023, 8:34 AM
inka requested review of this revision.Jul 27 2023, 8:34 AM
michal accepted this revision.Jul 28 2023, 8:13 AM
This revision is now accepted and ready to land.Jul 28 2023, 8:13 AM
ashoat added inline comments.Jul 28 2023, 11:04 AM
web/redux/redux-setup.js
154–163 ↗(On Diff #29139)

You can do this all in one declaration

inka updated this revision to Diff 29479.Aug 2 2023, 4:48 AM

Address review, rebase

Harbormaster completed remote builds in B21486: Diff 29479.Aug 2 2023, 5:12 AM
Closed by commit rCOMM01332e50f17b: [lib, web] Use sessionId from keyserverStore (authored by inka). · Explain WhyAug 4 2023, 1:06 AM
This revision was automatically updated to reflect the committed changes.
inka added a commit: rCOMM01332e50f17b: [lib, web] Use sessionId from keyserverStore.

Revision Contents
Changeset List

PathSize
lib/
selectors/
4 lines
5 lines
4 lines
shared/
7 lines
web/
redux/
12 lines
selectors/
3 lines

Diff 29479

View Options

lib/selectors/account-selectors.js

Loading...
View Options

lib/selectors/keyserver-selectors.js

Loading...
View Options

lib/selectors/server-calls.js

Loading...
View Options

lib/shared/session-utils.js

Loading...
View Options

web/redux/redux-setup.js

Loading...
View Options

web/selectors/socket-selectors.js

Loading...