Paths

Table of Contentst

Differential D8719

[keyserver][lib][web][native] Move updatesCurrentAsOf field to keyserverSotre
ClosedPublic
Actions

Authored by inka on Aug 3 2023, 6:48 AM.

Tags

None

Referenced Files

	Unknown Object (File)
	Mon, Nov 4, 6:29 PM

	Unknown Object (File)
	Fri, Nov 1, 1:33 PM

	Unknown Object (File)
	Mon, Oct 28, 1:55 PM

	Unknown Object (File)
	Sat, Oct 19, 4:41 AM

	Unknown Object (File)
	Oct 13 2024, 6:53 AM

	Unknown Object (File)
	Oct 12 2024, 6:57 PM

	Unknown Object (File)
	Oct 4 2024, 3:18 PM

	Unknown Object (File)
	Oct 2 2024, 10:17 PM

Subscribers

Details

Reviewers

michal
kamil

Commits

rCOMMa084a5faeda3: [keyserver][lib][web][native] Move updatesCurrentAsOf field to keyserverSotre

Summary

issue: https://linear.app/comm/issue/ENG-4458/refactor-updatescurrentasof-field
For now, we are using the id of our keyserver. In the future, actions that change fields in the keyserverStore will include in their payload the id of the keyserver the action is related to. That
id will be used in place of ashoatKeyserverID. Thiss will be done during https://linear.app/comm/issue/ENG-4440/refactor-redux-fields-second-iteration-refactor-actions

Test Plan

Ran yarn flow-all. Checked with redux devtools that the field gets correctly migrated to keyserverStore

Diff Detail

Repository

Branch

inka/redux

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

inka created this revision.Aug 3 2023, 6:48 AM

Herald added subscribers: tomek, ashoat. · View Herald TranscriptAug 3 2023, 6:48 AM

Harbormaster completed remote builds in B21510: Diff 29507.Aug 3 2023, 11:40 AM

inka requested review of this revision.Aug 3 2023, 11:40 AM

Fix promise

Fix reducing

inka added inline comments.Aug 4 2023, 1:37 AM

lib/reducers/keyserver-reducer.js
58–62 ↗	(On Diff #29532)	This comes from that `reduceUpdatesCurrentAsOf` changes `updatesCurrentAsOf` on those actions

Harbormaster completed remote builds in B21526: Diff 29531.Aug 4 2023, 1:40 AM

Harbormaster completed remote builds in B21527: Diff 29532.Aug 4 2023, 2:04 AM

michal accepted this revision.Aug 16 2023, 1:28 AM

This revision is now accepted and ready to land.Aug 16 2023, 1:28 AM

Closed by commit rCOMMa084a5faeda3: [keyserver][lib][web][native] Move updatesCurrentAsOf field to keyserverSotre (authored by inka). · Explain WhyAug 21 2023, 6:54 AM

This revision was automatically updated to reflect the committed changes.

inka added a commit: rCOMMa084a5faeda3: [keyserver][lib][web][native] Move updatesCurrentAsOf field to keyserverSotre.

Revision Contents
Changeset List

Path

Size

keyserver/

src/

responders/

website-responders.js

14 lines

lib/

reducers/

keyserver-reducer.js

34 lines

master-reducer.js

26 lines

selectors/

keyserver-selectors.js

13 lines

socket-selectors.js

3 lines

types/

keyserver-types.js

2 lines

1 line

native/

push/

push-handler.react.js

3 lines

redux/

19 lines

8 lines

1 line

web/

redux/

1 line

Diff 29531

keyserver/src/responders/website-responders.js

Loading...

lib/reducers/keyserver-reducer.js

Loading...

lib/reducers/master-reducer.js

Loading...

lib/selectors/keyserver-selectors.js

Loading...

lib/selectors/socket-selectors.js

Loading...

lib/types/keyserver-types.js

Loading...

lib/types/redux-types.js

Loading...

native/push/push-handler.react.js

Loading...

native/redux/persist.js

Loading...

native/redux/redux-setup.js

Loading...

native/redux/state-types.js

Loading...

web/redux/redux-setup.js

Loading...