Page MenuHomePhabricator
Differential D8744

[lib] Handle new id schema in thread regexes
ClosedPublic
Actions

Authored by michal on Aug 7 2023, 2:38 AM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Nov 11, 5:43 AM
Unknown Object (File)
Mon, Nov 11, 4:52 AM
Unknown Object (File)
Sat, Oct 19, 5:06 AM
Unknown Object (File)
Sat, Oct 19, 5:06 AM
Unknown Object (File)
Sat, Oct 19, 5:06 AM
Unknown Object (File)
Sat, Oct 19, 5:04 AM
Unknown Object (File)
Sep 24 2024, 4:28 AM
Unknown Object (File)
Aug 29 2024, 8:49 PM
View All 59 Files
Subscribers
ashoat

Details

Reviewers
tomek
ginsu
rohan
Commits
rCOMMc054a1e8ba3f: [lib] Handle new id schema in thread regexes
Summary

ENG-4586

Updates threadRegex in url-utils.js and pendingThreadIDRegex to handle both old and new id schemas.

Test Plan
  • checked if navigating back and forth works on web and on desktop
  • searched for regex in our codebase and checked if there are any more instances that need to be updated
  • yarn test

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Revision Contents
Changeset List

PathSize
lib/
shared/
4 lines
9 lines
utils/
3 lines
3 lines
18 lines

Diff 29573

View Options

lib/shared/thread-utils.js

Loading...
View Options

lib/shared/thread-utils.test.js

Loading...
View Options

lib/utils/url-utils.js

Loading...
View Options

lib/utils/validation-utils.js

Loading...
View Options

lib/utils/validation-utils.test.js

Loading...