Page MenuHomePhabricator
Differential D8745

[lib] Update id constants
ClosedPublic
Actions

Authored by michal on Aug 7 2023, 3:49 AM.
Tags
None
Referenced Files
F2894164: D8745.id29576.diff
Fri, Oct 4, 3:01 PM
Unknown Object (File)
Fri, Sep 20, 7:48 AM
Unknown Object (File)
Wed, Sep 18, 8:28 PM
Unknown Object (File)
Sun, Sep 8, 6:44 PM
Unknown Object (File)
Aug 29 2024, 9:00 PM
Unknown Object (File)
Aug 29 2024, 9:00 PM
Unknown Object (File)
Aug 29 2024, 8:59 PM
Unknown Object (File)
Aug 29 2024, 8:59 PM
View All 46 Files
Subscribers
ashoat

Details

Reviewers
tomek
bartek
Commits
rCOMM72a3200ceb2c: [lib] Update id constants
Summary

ENG-4595
Not all ids were converted

Test Plan
  • for bots.js -> added a console.log in keyserver and web code and checked that only web had a prefix
  • for comm-staff-community (I replaced 311733 with id of one of communities on my dev env for testing)
    • checked id: '311733', sent an image on web, confirmed that there is no "encryptionKey" in extra column in uploads
    • checked id: process.env['KEYSERVER'] ? '311733' : '256|311733', sent an image on web, confirmed that there is "encryptionKey"
  • Searched for id: ', id = ', '1, '2 etc. (case insensitive) and checked if there are any other constants
  • Checked files in facts/ for any id constants

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Revision Contents
Changeset List

PathSize
lib/
facts/
2 lines
2 lines

Diff 29576

View Options

lib/facts/bots.js

Loading...
View Options

lib/facts/comm-staff-community.js

Loading...