[web] Show loading state during siwe_auth server call
ClosedPublic
Actions

Authored by ashoat on Aug 7 2023, 12:57 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Tue, Oct 22, 6:36 AM

	Unknown Object (File)
	Tue, Oct 22, 6:36 AM

	Unknown Object (File)
	Tue, Oct 22, 6:35 AM

	Unknown Object (File)
	Tue, Oct 22, 5:03 AM

	Unknown Object (File)
	Tue, Oct 8, 4:33 PM

	Unknown Object (File)
	Tue, Oct 8, 10:46 AM

	Unknown Object (File)
	Tue, Oct 8, 7:00 AM

	Unknown Object (File)
	Tue, Oct 8, 5:32 AM

View All Files

Subscribers

tomek

Details

Reviewers

atul
ginsu

Commits

rCOMMa3a219af2cc0: [web] Show loading state during siwe_auth server call

Summary

Solves ENG-4326. We should show some sort of loading state while the server call is ongoing.

Test Plan

Diff Detail

Repository

rCOMM Comm

Branch

ashoat/siwe

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

ashoat created this revision.Aug 7 2023, 12:57 PM

Herald added a subscriber: tomek. · View Herald TranscriptAug 7 2023, 12:57 PM

ashoat edited the test plan for this revision. (Show Details)Aug 7 2023, 1:07 PM

ashoat edited the test plan for this revision. (Show Details)

Harbormaster completed remote builds in B21574: Diff 29598.Aug 7 2023, 1:19 PM

ashoat requested review of this revision.Aug 7 2023, 1:19 PM

ginsu accepted this revision.Aug 7 2023, 2:19 PM

This revision is now accepted and ready to land.Aug 7 2023, 2:19 PM

Closed by commit rCOMMa3a219af2cc0: [web] Show loading state during siwe_auth server call (authored by ashoat). · Explain WhyAug 8 2023, 5:47 AM

This revision was automatically updated to reflect the committed changes.

ashoat added a commit: rCOMMa3a219af2cc0: [web] Show loading state during siwe_auth server call.

Revision Contents
Changeset List

Path

Size

web/

account/

siwe-login-form.react.js

10 lines

Diff 29598

View Options

web/account/siwe-login-form.react.js

[web] Show loading state during siwe_auth server callClosedPublicActions