[native] Consume `useNativeUpdateThreadImageAvatar` in `useSelectFromGalleryAndUpdateImageAvatar`
ClosedPublic
Actions

Authored by atul on Aug 5 2023, 8:36 PM.

Details

Reviewers

ashoat
ginsu

Commits

rCOMM77ddd5a08fb9: [native] Consume `useNativeUpdateThreadImageAvatar` in…

Summary

Consume platform-specific nativeUpdateThreadAvatar instead of "base" updateThreadAvatar in useSelectFromGalleryAndUpdateImageAvatar.

Depends on D8740

NOTE: This is the `thread avatar version" of D8340. Probably could've been merged with D8740, but matching what I did for user avatars.

Test Plan

Ensure that selectFromGalleryAndUpdateThreadAvatar continues to work as expected. Break endpoint and ensure that platform-specific alert appears.

Diff Detail

Repository

rCOMM Comm

Branch

arcpatch-D8741 (branched from master)

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

atul created this revision.Aug 5 2023, 8:36 PM

Herald added a subscriber: tomek. · View Herald TranscriptAug 5 2023, 8:36 PM

atul published this revision for review.Aug 5 2023, 8:36 PM

Harbormaster completed remote builds in B21552: Diff 29565.Aug 5 2023, 8:56 PM

ashoat accepted this revision.Aug 6 2023, 6:57 AM

This revision is now accepted and ready to land.Aug 6 2023, 6:57 AM

rebase and land

This revision was landed with ongoing or failed builds.Aug 8 2023, 12:25 AM

Closed by commit rCOMM77ddd5a08fb9: [native] Consume `useNativeUpdateThreadImageAvatar` in… (authored by atul). · Explain Why

This revision was automatically updated to reflect the committed changes.

atul added a commit: rCOMM77ddd5a08fb9: [native] Consume `useNativeUpdateThreadImageAvatar` in….

Harbormaster completed remote builds in B21583: Diff 29608.Aug 8 2023, 12:40 AM

Revision Contents
Changeset List

Path

Size

native/

avatars/

avatar-hooks.js

8 lines

Diff 29608

View Options

native/avatars/avatar-hooks.js

[native] Consume `useNativeUpdateThreadImageAvatar` in `useSelectFromGalleryAndUpdateImageAvatar`ClosedPublicActions