[keyserver][lib][native][web] Remove urlPrefix from BaseAppState
ClosedPublic
Actions

Authored by inka on Aug 15 2023, 8:01 AM.

Details

Reviewers

michal
kamil

Commits

rCOMMae40a680874e: [keyserver][lib][native][web] Remove urlPrefix from BaseAppState

Summary

issue: https://linear.app/comm/issue/ENG-4459/refactor-urlprefix-field

Test Plan

ran yarn flow-all. Checked that the app still works - connects to the keyserver and its possible to send messages. Checked that the migration is succeful

Diff Detail

Repository

rCOMM Comm

Branch

inka/redux

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

inka created this revision.Aug 15 2023, 8:01 AM

Herald added subscribers: tomek, ashoat. · View Herald TranscriptAug 15 2023, 8:01 AM

inka added a parent revision: D8814: [lib][native][web] Use urlPrefix from keysererStore.Aug 15 2023, 8:02 AM

inka added inline comments.Aug 15 2023, 8:08 AM

lib/reducers/master-reducer.js
149	We hardcode `ashoatKeyserverID` temporarily here. During https://linear.app/comm/issue/ENG-4462/refactor-lastcommunicatedplatformdetails-field we will make `lastCommunicatedPlatformDetails` be keyed by keyservers id, not urlPrefix. During https://linear.app/comm/issue/ENG-4440/refactor-redux-fields-second-iteration-refactor-actions we will make the actions keep the id of the related keyserver in their payloads