Page MenuHomePhabricator
Differential D8802

[web] Introduce barebones `EditThreadAvatar` component
ClosedPublic
Actions

Authored by atul on Aug 14 2023, 1:49 AM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Dec 17, 1:10 AM
Unknown Object (File)
Tue, Dec 17, 1:10 AM
Unknown Object (File)
Tue, Dec 17, 1:10 AM
Unknown Object (File)
Tue, Dec 17, 1:10 AM
Unknown Object (File)
Tue, Dec 17, 1:08 AM
Unknown Object (File)
Nov 23 2024, 1:00 PM
Unknown Object (File)
Nov 16 2024, 11:01 AM
Unknown Object (File)
Nov 16 2024, 11:00 AM
View All 92 Files
Subscribers
tomek

Details

Reviewers
ashoat
ginsu
Commits
rCOMMdb9e97344849: [web] Introduce barebones `EditThreadAvatar` component
Summary

Introduce barebones EditThreadAvatar component. For now just shows spinner if threadAvatarSaveInProgress.

EditThreadAvatarMenu will be introduced in next diff.

Depends on D8801

Test Plan

Appears as expected in ThreadSettingsGeneralTab when editingAvatarsOnWebEnabled is true.

Diff Detail

Repository
rCOMM Comm
Branch
arcpatch-D8802 (branched from master)
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

atul created this revision.Aug 14 2023, 1:49 AM
Herald added a subscriber: tomek. · View Herald TranscriptAug 14 2023, 1:49 AM
atul published this revision for review.Aug 14 2023, 1:50 AM
Harbormaster completed remote builds in B21724: Diff 29851.Aug 14 2023, 2:08 AM
ginsu accepted this revision.Aug 14 2023, 7:48 PM

code looks good, but could we also get a screenshot of what ThreadSettingsGeneralTab looks like with editingAvatarsOnWebEnabled set to true

This revision is now accepted and ready to land.Aug 14 2023, 7:48 PM
atul added a comment.Aug 16 2023, 11:18 AM
In D8802#259870, @ginsu wrote:

code looks good, but could we also get a screenshot of what ThreadSettingsGeneralTab looks like with editingAvatarsOnWebEnabled set to true

4cc7d1.png (1×856 px, 109 KB)

It's just placed at the top for now. Layout/styling will be handled in subsequent diff.

atul updated this revision to Diff 29972.Aug 16 2023, 11:18 AM

rebase and land

Harbormaster completed remote builds in B21808: Diff 29972.Aug 16 2023, 11:38 AM
Closed by commit rCOMMdb9e97344849: [web] Introduce barebones `EditThreadAvatar` component (authored by atul). · Explain WhyAug 16 2023, 11:40 AM
This revision was automatically updated to reflect the committed changes.
atul added a commit: rCOMMdb9e97344849: [web] Introduce barebones `EditThreadAvatar` component.

Revision Contents
Changeset List

PathSize
web/
avatars/
8 lines
35 lines
modals/
threads/
settings/
8 lines

Diff 29972

View Options

web/avatars/edit-thread-avatar.css

Loading...
View Options

web/avatars/edit-thread-avatar.react.js

Loading...
View Options

web/modals/threads/settings/thread-settings-general-tab.react.js

Loading...