[web] Add `showSpinner` prop to `ThreadAvatar`
ClosedPublic
Actions

Authored by atul on Aug 14 2023, 12:05 AM.

Details

Reviewers

ashoat
ginsu

Commits

rCOMM3a7292332c36: [web] Add `showSpinner` prop to `ThreadAvatar`

Summary

We need this for when we introduce EditThreadAvatar.

We just add showSpinner prop to ThreadAvatar to be passed to underlying Avatar component.

Depends on D8800 (kind of)

Test Plan

Tested implicitly by subsequent diffs (observed that spinner spun when thread avatar update was in progress).

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

atul created this revision.Aug 14 2023, 12:05 AM

Herald added a subscriber: tomek. · View Herald TranscriptAug 14 2023, 12:05 AM

atul published this revision for review.Aug 14 2023, 12:06 AM

Harbormaster completed remote builds in B21723: Diff 29850.Aug 14 2023, 12:24 AM

atul added a child revision: D8802: [web] Introduce barebones `EditThreadAvatar` component.Aug 14 2023, 1:49 AM

ginsu accepted this revision.Aug 14 2023, 9:21 AM

This revision is now accepted and ready to land.Aug 14 2023, 9:21 AM

rebase and land

This revision was landed with ongoing or failed builds.Aug 14 2023, 10:36 PM

Closed by commit rCOMM3a7292332c36: [web] Add `showSpinner` prop to `ThreadAvatar` (authored by atul). · Explain Why

This revision was automatically updated to reflect the committed changes.

atul added a commit: rCOMM3a7292332c36: [web] Add `showSpinner` prop to `ThreadAvatar`.

Harbormaster completed remote builds in B21740: Diff 29876.Aug 14 2023, 10:53 PM

Revision Contents
Changeset List

Path

Size

web/

avatars/

thread-avatar.react.js

11 lines

Diff 29877

View Options

web/avatars/thread-avatar.react.js

[web] Add `showSpinner` prop to `ThreadAvatar`ClosedPublicActions