Paths

Table of Contentst

-
web/avatars/
-
avatars/
-
thread-avatar.react.js

Differential D8801

[web] Add `showSpinner` prop to `ThreadAvatar`
ClosedPublic
Actions

Authored by atul on Aug 14 2023, 12:05 AM.

Tags

None

Referenced Files

	Unknown Object (File)
	Mar 8 2025, 10:48 PM

	Unknown Object (File)
	Feb 28 2025, 2:01 AM

	Unknown Object (File)
	Feb 26 2025, 11:47 PM

	Unknown Object (File)
	Feb 26 2025, 11:46 PM

	Unknown Object (File)
	Feb 24 2025, 10:10 PM

	Unknown Object (File)
	Feb 22 2025, 5:09 AM

	Unknown Object (File)
	Feb 20 2025, 9:35 PM

	Unknown Object (File)
	Feb 13 2025, 4:14 AM

View All 89 Files

Subscribers

Details

Reviewers

ashoat
ginsu

Commits

rCOMM3a7292332c36: [web] Add `showSpinner` prop to `ThreadAvatar`

Summary

We need this for when we introduce EditThreadAvatar.

We just add showSpinner prop to ThreadAvatar to be passed to underlying Avatar component.

Depends on D8800 (kind of)

Test Plan

Tested implicitly by subsequent diffs (observed that spinner spun when thread avatar update was in progress).

Diff Detail

Repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

atul created this revision.Aug 14 2023, 12:05 AM

Herald added a subscriber: tomek. · View Herald TranscriptAug 14 2023, 12:05 AM

atul published this revision for review.Aug 14 2023, 12:06 AM

Harbormaster completed remote builds in B21723: Diff 29850.Aug 14 2023, 12:24 AM

atul added a child revision: D8802: [web] Introduce barebones `EditThreadAvatar` component.Aug 14 2023, 1:49 AM

ginsu accepted this revision.Aug 14 2023, 9:21 AM

This revision is now accepted and ready to land.Aug 14 2023, 9:21 AM

rebase and land

This revision was landed with ongoing or failed builds.Aug 14 2023, 10:36 PM

Closed by commit rCOMM3a7292332c36: [web] Add `showSpinner` prop to `ThreadAvatar` (authored by atul). · Explain Why

This revision was automatically updated to reflect the committed changes.

atul added a commit: rCOMM3a7292332c36: [web] Add `showSpinner` prop to `ThreadAvatar`.

Harbormaster completed remote builds in B21740: Diff 29876.Aug 14 2023, 10:53 PM

Revision Contents
Changeset List

Path

Size

web/

avatars/

thread-avatar.react.js

11 lines

Diff 29877

web/avatars/thread-avatar.react.js

	Show First 20 Lines • Show All 130 Lines • ▼ Show 20 Lines		if (!hasNonce) {
	return (			return (
	<div className={css.wrapper}>			<div className={css.wrapper}>
	<div className={css.walletDisplay}>			<div className={css.walletDisplay}>
	<span className={css.walletDisplayText}>Wallet Connected:</span>			<span className={css.walletDisplayText}>Wallet Connected:</span>
	<ConnectButton />			<ConnectButton />
	</div>			</div>
	<p>{siweMessageSigningExplanationStatements[0]}</p>			<p>{siweMessageSigningExplanationStatements[0]}</p>
	<p>{siweMessageSigningExplanationStatements[1]}</p>			<p>{siweMessageSigningExplanationStatements[1]}</p>
				<p>
				By signing up, you agree to our{' '}
				<a href="https://comm.app/terms">Terms of Use</a> &{' '}
				<a href="https://comm.app/privacy">Privacy Policy</a>.
				</p>
	<div className={css.button} onClick={onClick}>			<div className={css.button} onClick={onClick}>
	Sign in			Sign in
	</div>			</div>
	</div>			</div>
	);			);
	}			}
	}			}

	Show All 22 Lines