[identity] add ttl to nonces tables
ClosedPublic
Actions

Authored by varun on Aug 16 2023, 12:20 AM.

Details

Reviewers

• jon
bartek

Commits

rCOMMf45d933ef293: [identity] add ttl to nonces tables

Summary

Added an expiration time as an RFC 3339 date-and-time string and as a UNIX timestamp to DynamoDB. I added the RFC 3339 version to preserve precision, since UNIX timestamps only go to the second. Open to removing it, though.

The UNIX timestamp lets us set a TTL on the DDB table with Terraform (see next diff). DynamoDB will then remove expired nonces, saving us from having to implement a cron job ourselves.

Depends on D8825

Test Plan

verified that the expirationTime and expirationTimeUnix attributes appeared in my local DDB table.

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

varun created this revision.Aug 16 2023, 12:20 AM

Herald added subscribers: tomek, ashoat. · View Herald TranscriptAug 16 2023, 12:20 AM

Harbormaster completed remote builds in B21784: Diff 29938.Aug 16 2023, 12:37 AM

varun requested review of this revision.Aug 16 2023, 12:37 AM

Looks good, I just want to make sure: should the expiration timestamp be in seconds or milliseconds?
It's about nonce_data.expiration_time.timestamp() vs timestamp_millis()

The term "UNIX timestamp" usually is used for both

This revision now requires changes to proceed.Aug 16 2023, 5:31 AM

Never mind, I found it here: https://docs.aws.amazon.com/amazondynamodb/latest/developerguide/time-to-live-ttl-before-you-start.html