Remove redundant warnings about notifications without message infos that exceed limits
ClosedPublic
Actions

Authored by marcin on Aug 1 2023, 6:40 AM.

Details

Reviewers

tomek

Commits

rCOMM4b2634dd0ae4: Remove redundant warnings about notifications without message infos that exceed…

Summary

this differential removes unecessary warnings. We don't have to check if notification exceeds FCM/APN size limits after messageInfos removal. The reason for this is that we construct notification body based on ResolvedNotifTexts, which trims
texts in notification: https://github.com/CommE2E/comm/blob/master/lib/shared/notif-utils.js#L50-L57.

Test Plan

Build iOS and Android apps.
Send large (more than 8000 characters) notification from web.
Ensure that notification is displayed on both devices.
Kill keyserver.
Open both apps.
Ensure notifications weren't persisted (since no messageInfos).

Diff Detail

Repository

rCOMM Comm

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

marcin created this revision.Aug 1 2023, 6:40 AM

Herald added a subscriber: ashoat. · View Herald TranscriptAug 1 2023, 6:40 AM

marcin added a parent revision: D8588: Refactor olm-session-updater to enable to conditionally skip database content update.Aug 1 2023, 6:54 AM

marcin added a child revision: D8697: Significant refactor of notification encryption code.

Rebase to update commit message

Harbormaster completed remote builds in B21455: Diff 29431.Aug 1 2023, 7:15 AM

Harbormaster completed remote builds in B21459: Diff 29435.Aug 1 2023, 8:10 AM

marcin requested review of this revision.Aug 1 2023, 8:10 AM

tomek accepted this revision.Aug 2 2023, 2:04 AM

This revision is now accepted and ready to land.Aug 2 2023, 2:04 AM

Rebase before landing

Harbormaster completed remote builds in B21893: Diff 30074.Aug 18 2023, 7:27 AM

Closed by commit rCOMM4b2634dd0ae4: Remove redundant warnings about notifications without message infos that exceed… (authored by marcin). · Explain WhyAug 18 2023, 7:53 AM

This revision was automatically updated to reflect the committed changes.

marcin added a commit: rCOMM4b2634dd0ae4: Remove redundant warnings about notifications without message infos that exceed….

Revision Contents
Changeset List

Path

Size

keyserver/

src/

push/

send.js

15 lines

Diff 30074

View Options

keyserver/src/push/send.js

	// @flow			// @flow

	import type {			import type {
	MessageReportCreationRequest,			MessageReportCreationRequest,
	MessageReportCreationResult,			MessageReportCreationResult,
	} from '../types/message-report-types.js';			} from '../types/message-report-types.js';
	import type { CallServerEndpoint } from '../utils/call-server-endpoint.js';			import { extractKeyserverIDFromID } from '../utils/action-utils.js';
				import type { CallKeyserverEndpoint } from '../utils/keyserver-call.js';
				import { useKeyserverCall } from '../utils/keyserver-call.js';

	const sendMessageReportActionTypes = Object.freeze({			const sendMessageReportActionTypes = Object.freeze({
	started: 'SEND_MESSAGE_REPORT_STARTED',			started: 'SEND_MESSAGE_REPORT_STARTED',
	success: 'SEND_MESSAGE_REPORT_SUCCESS',			success: 'SEND_MESSAGE_REPORT_SUCCESS',
	failed: 'SEND_MESSAGE_REPORT_FAILED',			failed: 'SEND_MESSAGE_REPORT_FAILED',
	});			});
	const sendMessageReport =			const sendMessageReport =
	(			(
	callServerEndpoint: CallServerEndpoint,			callKeyserverEndpoint: CallKeyserverEndpoint,
	): ((			): ((
	request: MessageReportCreationRequest,			input: MessageReportCreationRequest,
	) => Promise<MessageReportCreationResult>) =>			) => Promise<MessageReportCreationResult>) =>
	async request => {			async input => {
	return await callServerEndpoint('create_message_report', request);			const keyserverID = extractKeyserverIDFromID(input.messageID);
				const requests = { [keyserverID]: input };

				const responses = await callKeyserverEndpoint(
				'create_message_report',
				requests,
				);
				const response = responses[keyserverID];

				return { messageInfo: response.messageInfo };
	};			};

	export { sendMessageReportActionTypes, sendMessageReport };			function useSendMessageReport(): (
				input: MessageReportCreationRequest,
				) => Promise<MessageReportCreationResult> {
				return useKeyserverCall(sendMessageReport);
				}

				export { sendMessageReportActionTypes, useSendMessageReport };

Remove redundant warnings about notifications without message infos that exceed limitsClosedPublicActions