Differential D8930

[rust-node-addon] add client method to call getInboundKeysForUser
ClosedPublic
Actions

Authored by varun on Aug 23 2023, 8:33 AM.

Tags

None

Referenced Files

	F3515240: D8930.diff
	Sun, Dec 22, 8:13 AM

	Unknown Object (File)
	Mon, Dec 16, 10:27 AM

	Unknown Object (File)
	Mon, Dec 16, 10:27 AM

	Unknown Object (File)
	Mon, Dec 16, 10:27 AM

	Unknown Object (File)
	Sat, Dec 14, 9:01 PM

	Unknown Object (File)
	Wed, Dec 4, 5:31 AM

	Unknown Object (File)
	Sat, Nov 23, 1:51 AM

	Unknown Object (File)
	Nov 8 2024, 10:48 AM

Subscribers

Details

Reviewers

Commits

rCOMMb82d22a09a85: [rust-node-addon] add client method to call getInboundKeysForUser

Summary

client method calls the mentioned Identity service RPC. we return the keys specific to the device ID provided.

The error handling can be further improved later. For now I'm just returning Generic errors and logging appropriately.

Test Plan

called the new client method from keyserver.js after writing some test data to DDB. i got back the keys as expected.
tried calling the method with an invalid device ID and got an error.
tried calling the method with an invalid username and got an error.
tried calling the method with a malformed identifier_type string ("usernam") and got an error

Diff Detail

Repository

Branch

new-responder (branched from master)

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

varun created this revision.Aug 23 2023, 8:33 AM

Herald added subscribers: tomek, ashoat. · View Herald TranscriptAug 23 2023, 8:33 AM

remove unnecessary comments

Harbormaster completed remote builds in B22046: Diff 30262.Aug 23 2023, 8:57 AM

varun requested review of this revision.Aug 23 2023, 8:57 AM

Harbormaster completed remote builds in B22045: Diff 30261.Aug 23 2023, 8:58 AM

bartek accepted this revision.Aug 23 2023, 12:27 PM

bartek added inline comments.

keyserver/addons/rust-node-addon/src/identity_client/mod.rs
142–144 ↗	(On Diff #30262)	Can it be done this way? The same for others

This revision is now accepted and ready to land.Aug 23 2023, 12:27 PM

varun added inline comments.Aug 30 2023, 12:04 PM

keyserver/addons/rust-node-addon/src/identity_client/mod.rs
142–144 ↗	(On Diff #30262)	yep much cleaner!

Closed by commit rCOMMb82d22a09a85: [rust-node-addon] add client method to call getInboundKeysForUser (authored by varun). · Explain WhyAug 30 2023, 12:04 PM

This revision was automatically updated to reflect the committed changes.

varun added a commit: rCOMMb82d22a09a85: [rust-node-addon] add client method to call getInboundKeysForUser.

kamil mentioned this in D8476: [Keyserver] Publish prekeys to identity service for cron job.Sep 8 2023, 4:34 AM

Revision Contents
Changeset List

Path

Size

keyserver/

addons/

rust-node-addon/

rust-binding-types.js

17 lines

src/

identity_client/

get_inbound_keys_for_user.rs

36 lines

60 lines

Diff 30261

keyserver/addons/rust-node-addon/rust-binding-types.js

Loading...

keyserver/addons/rust-node-addon/src/identity_client/get_inbound_keys_for_user.rs

Loading...

keyserver/addons/rust-node-addon/src/identity_client/mod.rs

Loading...