[lib/native] Remain consistent with url naming pattern
ClosedPublic
Actions

Authored by rohan on Sep 8 2023, 7:52 AM.

Details

Reviewers

atul
ginsu

Commits

rCOMM67bdf1ce42ff: [lib/native] Remain consistent with url naming pattern

Summary

Quick follow up for this comment. Though we no longer use parseKeysFromQRCodeURL, we have parseInstallReferrerFromInviteLinkURL. I decided to
match the convention with inviteLinkUrl and qrCodeLinkUrl, so I've renamed parseInstallReferrerFromInviteLinkURL to parseInstallReferrerFromInviteLinkUrl.

Test Plan

Ran flow and confirmed no errors

Diff Detail

Repository

rCOMM Comm

Branch

names

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

rohan created this revision.Sep 8 2023, 7:52 AM

Herald added subscribers: tomek, ashoat. · View Herald TranscriptSep 8 2023, 7:52 AM

rohan mentioned this in D8934: [keyserver/lib/web/native] Support external cameras scanning the QR code.Sep 8 2023, 7:53 AM

Harbormaster completed remote builds in B22452: Diff 30869.Sep 8 2023, 8:10 AM

rohan requested review of this revision.Sep 8 2023, 8:10 AM

ginsu accepted this revision.Sep 8 2023, 8:57 AM

This revision is now accepted and ready to land.Sep 8 2023, 8:57 AM

actually after doing a quick global search it seems like the pattern is to have url be "URL" (it's not perfect throughout the codebase, but seems like the majority of cases go with all caps) . Could we make inviteLinkUrl => inviteLinkURL and qrCodeLinkUrl => qrCodeLinkURL

This revision now requires changes to proceed.Sep 8 2023, 9:01 AM

Rename all instances of '...Url' with '...URL'

Harbormaster completed remote builds in B22457: Diff 30874.Sep 8 2023, 10:14 AM

ginsu accepted this revision.Sep 8 2023, 5:47 PM

This revision is now accepted and ready to land.Sep 8 2023, 5:47 PM

Closed by commit rCOMM67bdf1ce42ff: [lib/native] Remain consistent with url naming pattern (authored by rohan). · Explain WhySep 11 2023, 12:49 PM

This revision was automatically updated to reflect the committed changes.

rohan added a commit: rCOMM67bdf1ce42ff: [lib/native] Remain consistent with url naming pattern.