Page MenuHomePhabricator
Differential D9157

[lib] Add blobServiceUpload upload action
ClosedPublic
Actions

Authored by • patryk on Sep 12 2023, 1:53 PM.
Tags
None
Referenced Files
F3387357: D9157.diff
Fri, Nov 29, 9:00 AM
Unknown Object (File)
Tue, Nov 26, 2:54 AM
Unknown Object (File)
Mon, Nov 25, 11:51 PM
Unknown Object (File)
Mon, Nov 25, 11:47 PM
Unknown Object (File)
Sat, Nov 16, 3:16 AM
Unknown Object (File)
Mon, Nov 11, 6:17 PM
Unknown Object (File)
Thu, Oct 31, 12:52 PM
Unknown Object (File)
Thu, Oct 31, 12:52 PM
View All Files
Subscribers
ashoat
tomek

Details

Reviewers
bartek
atul
Commits
rCOMM0be4d7f5a5af: [lib] Add blobServiceUpload upload action
Summary

This diff introduces new upload action for blob service uploads.

Depends on D9154.

Test Plan

Tested later in the stack.

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

• patryk created this revision.Sep 12 2023, 1:53 PM
• patryk held this revision as a draft.
Herald added subscribers: tomek, ashoat. · View Herald TranscriptSep 12 2023, 1:53 PM
Harbormaster failed remote builds in B22546: Diff 30992!Sep 12 2023, 2:08 PM
• patryk added a child revision: D9159: [web] Use blobServiceUpload upload action.Sep 13 2023, 2:48 AM
• patryk added a child revision: D9163: [native] Use blobServiceUpload upload action.
• patryk edited the summary of this revision. (Show Details)Sep 13 2023, 2:55 AM
• patryk edited the test plan for this revision. (Show Details)
• patryk added a parent revision: D9154: [lib] Add uuid dependency.
• patryk updated this revision to Diff 31027.Sep 13 2023, 3:27 AM

Rebase

Harbormaster failed remote builds in B22576: Diff 31027!Sep 13 2023, 3:42 AM
bartek added a comment.Sep 14 2023, 4:00 AM

I'm not sure what's wrong about the uuid dependency (failed CI). Perhaps the wrong version is hoisted, which is strange

bartek added inline comments.Sep 14 2023, 4:07 AM
lib/actions/upload-actions.js
128

arguably we could name it blobSource or blobInput, but I don't have strong preference

• patryk published this revision for review.Sep 14 2023, 4:46 AM
bartek requested changes to this revision.Sep 18 2023, 5:11 AM

Requesting changes to fix failing CI - most likely wrong uuid version is being resolved, try the yarn why uuid command to confirm.

lib/utils/blob-service-upload.js
18

A good thing would be to destructure options to avoid repeatitions

const { timeout, onProgress, abortHandler } = options ?? {};

// ...
if (timeout) { ... }
This revision now requires changes to proceed.Sep 18 2023, 5:11 AM
• patryk updated this revision to Diff 31197.Sep 18 2023, 5:32 AM

Destructure options.

Harbormaster failed remote builds in B22670: Diff 31197!Sep 18 2023, 5:48 AM
• patryk updated this revision to Diff 31200.Sep 18 2023, 7:15 AM

Failing CI fix

Harbormaster completed remote builds in B22673: Diff 31200.Sep 18 2023, 7:41 AM
bartek accepted this revision.Sep 20 2023, 3:15 AM
This revision is now accepted and ready to land.Sep 20 2023, 3:15 AM
Closed by commit rCOMM0be4d7f5a5af: [lib] Add blobServiceUpload upload action (authored by • patryk). · Explain WhySep 28 2023, 12:56 AM
This revision was automatically updated to reflect the committed changes.
• patryk added a commit: rCOMM0be4d7f5a5af: [lib] Add blobServiceUpload upload action.

Revision Contents
Changeset List

PathSize
lib/
actions/
126 lines
utils/
83 lines

Diff 31027

View Options

lib/actions/upload-actions.js

Loading...
View Options

lib/utils/blob-service-upload.js

Loading...