Page MenuHomePhabricator

Encrypt all notifications on the keyserver for iOS devices
ClosedPublic

Authored by marcin on Sep 12 2023, 5:43 AM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Nov 10, 6:13 PM
Unknown Object (File)
Sun, Nov 10, 5:52 PM
Unknown Object (File)
Sun, Nov 10, 4:21 PM
Unknown Object (File)
Thu, Nov 7, 10:37 PM
Unknown Object (File)
Thu, Nov 7, 9:00 PM
Unknown Object (File)
Thu, Nov 7, 11:55 AM
Unknown Object (File)
Thu, Nov 7, 11:40 AM
Unknown Object (File)
Thu, Nov 7, 10:29 AM
Subscribers

Details

Summary

This differential enables encrypted notifications coalescing on the keyserver. Based on the code version of the client it is decided whether coalescible
notifications is going to be encrypted or not.

Test Plan
  1. Build iOS app.
  2. Open mariadb shell and execute select * from olm_sessions;. Remember the version column value of the last session.
  3. Send a couple of collapsible notifications.
  4. Execute select * from olm_sessions;. Ensure last session version column value didn't change.
  5. Update FUTURE_CODE_VERSION to 0.
  6. Send a couple of collapsible notifications. Ensure that coalescing takes place.
  7. Execute select * from olm_sessions;. Ensure last session version column value increased by the number of sent notifications.

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

Harbormaster returned this revision to the author for changes because remote builds failed.Sep 12 2023, 5:58 AM
Harbormaster failed remote builds in B22529: Diff 30967!

Check for collapseKey before assigning to headers in else branch.

This revision is now accepted and ready to land.Sep 13 2023, 3:29 AM
marcin retitled this revision from Encrypt all notifications on the keyserver to Encrypt all notifications on the keyserver for iOS devices.Sep 14 2023, 2:31 AM

1.Rebase before landing

  1. Use NEXT_CODE_VERSION to prepare for the release