Page MenuHomePhabricator
Differential D9163

[native] Use blobServiceUpload upload action
ClosedPublic
Actions

Authored by • patryk on Sep 12 2023, 2:00 PM.
Tags
None
Referenced Files
F3369108: D9163.diff
Mon, Nov 25, 9:49 PM
Unknown Object (File)
Thu, Nov 21, 2:21 PM
Unknown Object (File)
Wed, Nov 20, 4:39 AM
Unknown Object (File)
Fri, Nov 15, 5:29 PM
Unknown Object (File)
Thu, Nov 7, 2:13 PM
Unknown Object (File)
Thu, Oct 31, 12:51 PM
Unknown Object (File)
Thu, Oct 31, 12:51 PM
Unknown Object (File)
Thu, Oct 31, 12:51 PM
View All Files
Subscribers
ashoat
tomek

Details

Reviewers
bartek
atul
Commits
rCOMMf1a8c5ad6000: [native] Use blobServiceUpload upload action
Summary

This diff uses new blobServiceUpload upload action in input-state-container.

Depends on D9157.

Test Plan

Check if upload behavior hasn't changed.

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

• patryk created this revision.Sep 12 2023, 2:00 PM
• patryk held this revision as a draft.
Herald added subscribers: tomek, ashoat. · View Herald TranscriptSep 12 2023, 2:00 PM
Harbormaster failed remote builds in B22551: Diff 30997!Sep 12 2023, 2:23 PM
• patryk edited the summary of this revision. (Show Details)Sep 13 2023, 2:49 AM
• patryk edited the test plan for this revision. (Show Details)
• patryk added a parent revision: D9157: [lib] Add blobServiceUpload upload action.
• patryk published this revision for review.Sep 14 2023, 4:46 AM
bartek accepted this revision.Sep 18 2023, 4:55 AM
bartek added inline comments.
native/utils/blob-service-upload.js
36 ↗(On Diff #30997)
42 ↗(On Diff #30997)

Perhaps we can use the newer syntax here

This revision is now accepted and ready to land.Sep 18 2023, 4:55 AM
• patryk updated this revision to Diff 31198.Sep 18 2023, 5:34 AM
• patryk edited the summary of this revision. (Show Details)
• patryk edited the test plan for this revision. (Show Details)

Use new syntax

Harbormaster failed remote builds in B22671: Diff 31198!Sep 18 2023, 5:45 AM
• patryk updated this revision to Diff 31202.Sep 18 2023, 7:26 AM

Rebuild

Harbormaster failed remote builds in B22675: Diff 31202!Sep 18 2023, 7:37 AM
• patryk updated this revision to Diff 31204.Sep 18 2023, 7:44 AM

Fix flow bugs

Harbormaster completed remote builds in B22677: Diff 31204.Sep 18 2023, 8:02 AM
Closed by commit rCOMMf1a8c5ad6000: [native] Use blobServiceUpload upload action (authored by • patryk). · Explain WhySep 28 2023, 12:56 AM
This revision was automatically updated to reflect the committed changes.
• patryk added a commit: rCOMMf1a8c5ad6000: [native] Use blobServiceUpload upload action.

Revision Contents
Changeset List

PathSize
native/
input/
158 lines
utils/
54 lines

Diff 31204

View Options

native/input/input-state-container.react.js

Loading...
View Options

native/utils/blob-service-upload.js

Loading...