Page MenuHomePhabricator
Differential D9256

[web/native] Add threadHashes to threadStore
AbandonedPublic
Actions

Authored by michal on Sep 21 2023, 7:57 AM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Apr 1, 12:23 AM
Unknown Object (File)
Sun, Mar 30, 6:30 AM
Unknown Object (File)
Sat, Mar 29, 11:12 PM
Unknown Object (File)
Sat, Mar 29, 1:58 AM
Unknown Object (File)
Feb 23 2025, 9:11 AM
Unknown Object (File)
Feb 23 2025, 6:24 AM
Unknown Object (File)
Feb 23 2025, 6:23 AM
Unknown Object (File)
Feb 16 2025, 1:56 AM
View All 72 Files
Subscribers
ashoat

Details

Reviewers
inka
kamil
tomek
Summary

ENG-4959
Depends on D9255

Adding threadHashes to threadStore, and updating it in thread-store-ops.js. More explanation of the approach in the previous diff.

Test Plan

Load the web app, check if hashes are in the threadStore.
Load the native app, check that:

  • on first load the transform does not run (nothing persisted), migration runs and fills in the hashes
  • when redux state is saved it is saved with threadHashes
  • on subsequent loads, the threadHashes are correctly rehydrated

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Revision Contents
Changeset List

PathSize
keyserver/
src/
responders/
10 lines
lib/
ops/
14 lines
shared/
40 lines
types/
2 lines
native/
redux/
1 line
52 lines
web/
redux/
1 line

Diff 31339

View Options

keyserver/src/responders/redux-state-responders.js

  • This file was added.
require 'json'
package = JSON.parse(File.read(File.join(__dir__, '..', 'package.json')))
Pod::Spec.new do |s|
s.name = 'Thumbhash'
s.version = package['version']
s.summary = package['description']
s.description = package['description']
s.license = package['license']
s.author = 'Comm'
s.homepage = 'https://comm.app'
s.platform = :ios, '13.0'
s.swift_version = '5.4'
s.source = { git: 'https://github.com/CommE2E/comm' }
s.static_framework = true
s.dependency 'ExpoModulesCore'
# Swift/Objective-C compatibility
s.pod_target_xcconfig = {
'DEFINES_MODULE' => 'YES',
'SWIFT_COMPILATION_MODE' => 'wholemodule'
}
s.source_files = "**/*.{h,m,swift}"
end
View Options

lib/ops/thread-store-ops.js

  • This file was added.
require 'json'
package = JSON.parse(File.read(File.join(__dir__, '..', 'package.json')))
Pod::Spec.new do |s|
s.name = 'Thumbhash'
s.version = package['version']
s.summary = package['description']
s.description = package['description']
s.license = package['license']
s.author = 'Comm'
s.homepage = 'https://comm.app'
s.platform = :ios, '13.0'
s.swift_version = '5.4'
s.source = { git: 'https://github.com/CommE2E/comm' }
s.static_framework = true
s.dependency 'ExpoModulesCore'
# Swift/Objective-C compatibility
s.pod_target_xcconfig = {
'DEFINES_MODULE' => 'YES',
'SWIFT_COMPILATION_MODE' => 'wholemodule'
}
s.source_files = "**/*.{h,m,swift}"
end
View Options

lib/shared/thread-store-utils.js

  • This file was added.
require 'json'
package = JSON.parse(File.read(File.join(__dir__, '..', 'package.json')))
Pod::Spec.new do |s|
s.name = 'Thumbhash'
s.version = package['version']
s.summary = package['description']
s.description = package['description']
s.license = package['license']
s.author = 'Comm'
s.homepage = 'https://comm.app'
s.platform = :ios, '13.0'
s.swift_version = '5.4'
s.source = { git: 'https://github.com/CommE2E/comm' }
s.static_framework = true
s.dependency 'ExpoModulesCore'
# Swift/Objective-C compatibility
s.pod_target_xcconfig = {
'DEFINES_MODULE' => 'YES',
'SWIFT_COMPILATION_MODE' => 'wholemodule'
}
s.source_files = "**/*.{h,m,swift}"
end
View Options

lib/types/thread-types.js

  • This file was added.
require 'json'
package = JSON.parse(File.read(File.join(__dir__, '..', 'package.json')))
Pod::Spec.new do |s|
s.name = 'Thumbhash'
s.version = package['version']
s.summary = package['description']
s.description = package['description']
s.license = package['license']
s.author = 'Comm'
s.homepage = 'https://comm.app'
s.platform = :ios, '13.0'
s.swift_version = '5.4'
s.source = { git: 'https://github.com/CommE2E/comm' }
s.static_framework = true
s.dependency 'ExpoModulesCore'
# Swift/Objective-C compatibility
s.pod_target_xcconfig = {
'DEFINES_MODULE' => 'YES',
'SWIFT_COMPILATION_MODE' => 'wholemodule'
}
s.source_files = "**/*.{h,m,swift}"
end
View Options

native/redux/default-state.js

Loading...
View Options

native/redux/persist.js

Loading...
View Options

web/redux/default-state.js

Loading...