Page MenuHomePhabricator

[keyserver] Pass `--performance-schema` to MariaDB in `docker-compose`
ClosedPublic

Authored by atul on Sep 27 2023, 12:00 PM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Nov 26, 5:17 AM
Unknown Object (File)
Tue, Nov 26, 3:49 AM
Unknown Object (File)
Fri, Nov 15, 8:05 AM
Unknown Object (File)
Fri, Nov 15, 8:05 AM
Unknown Object (File)
Fri, Nov 15, 8:05 AM
Unknown Object (File)
Fri, Nov 15, 7:59 AM
Unknown Object (File)
Oct 15 2024, 4:09 AM
Unknown Object (File)
Oct 15 2024, 4:09 AM
Subscribers
None

Details

Summary

As I mentioned in D9304 it turns out we can totally just pass --performance-schema to mariadb. I was misled by some old MySQL (not MariaDB) docs as well as a comment someone left on GitHub that inaccurately stated that performance-schema had to be defined in a .cnf file and couldn't be passed as command line argument when started up. Annoying, but this is a much cleaner solution anyways.


Depends on D9304

Test Plan

Confirmed that performance_schema was set as expected (docker-compose up):

b6254f.png (1×2 px, 212 KB)

Diff Detail

Repository
rCOMM Comm
Branch
master
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

atul published this revision for review.Sep 27 2023, 12:01 PM
atul retitled this revision from [keyserver] Pass `--performance-schema` to MariaDB to [keyserver] Pass `--performance-schema` to MariaDB in `docker-compose`.
atul edited the test plan for this revision. (Show Details)

Does monitoring perf have any negative perf impacts?

This revision is now accepted and ready to land.Sep 27 2023, 12:36 PM

Does monitoring perf have any negative perf impacts?

Based on https://dev.mysql.com/blog-archive/performance-schema-great-power-comes-without-great-cost/#:~:text=Overall%2C%20as%20we%20see%20I,overall%20impact%20is%20relatively%20small, it's about 1-3%. That said, I think the potential gains exceed this small upfront cost. We can also disable it when we feel that things are in a good place.