[lib] Add hash functions to state sync spec
ClosedPublic
Actions

Authored by michal on Sep 29 2023, 5:20 AM.

Details

Reviewers

tomek
inka
kamil

Commits

rCOMMe919581da2fb: [lib] Add hash functions to state sync spec

Summary

Part of ENG-4959
Depends on D9267

Introduces new function to the sync spec: selector. It returns the spec with functions responsible for returning hashes for whole store, individual infos, and to return the list of all ids, using the current redux state. They will be used in the future diff instead of using the convertClientToServerInfos and hash.

Test Plan

yarn flow-all. Correctness of hashing is tested in the next diff.

Diff Detail

Repository

rCOMM Comm

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

michal created this revision.Sep 29 2023, 5:20 AM

Herald added a subscriber: ashoat. · View Herald TranscriptSep 29 2023, 5:20 AM

michal added a child revision: D9328: [lib] Use new hashing functions in state check.Sep 29 2023, 5:35 AM

Harbormaster completed remote builds in B22911: Diff 31544.Sep 29 2023, 5:38 AM

michal requested review of this revision.Sep 29 2023, 5:38 AM

tomek accepted this revision.Oct 3 2023, 3:25 AM

tomek added inline comments.

lib/shared/state-sync/entries-state-sync-spec.js
45–53	Do we have a plan on how it will look with multiple keyservers?
lib/shared/state-sync/state-sync-spec.js
30	Why do we include `StateSyncSpec` inside the returned value?

This revision is now accepted and ready to land.Oct 3 2023, 3:25 AM

Update to new threadHashingStatus

lib/shared/state-sync/entries-state-sync-spec.js
45–53	There's a few options: just pass keyserver id as an argument to these functions make the `selector` field be a function that takes a keyserver id and returns a selector for this specific keyserver Probably depends on how we structure the websocket code around multiple keyservers
lib/shared/state-sync/state-sync-spec.js
30	We still use the the `hashKey`, `innerHashSpec` fields in socket selector. Keeping them together with the hashing functions simplifies the code (see the next diff)