Page MenuHomePhabricator

[native] Use recovery callServerEndpoint when fetching notif keys in resolveInvalidatedCookie
ClosedPublic

Authored by ashoat on Oct 24 2023, 1:19 PM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Nov 20, 4:41 PM
Unknown Object (File)
Sat, Nov 16, 9:02 PM
Unknown Object (File)
Sat, Nov 16, 9:02 PM
Unknown Object (File)
Sat, Nov 16, 9:02 PM
Unknown Object (File)
Sat, Nov 16, 9:01 PM
Unknown Object (File)
Oct 29 2024, 4:18 PM
Unknown Object (File)
Oct 29 2024, 4:18 PM
Unknown Object (File)
Oct 29 2024, 2:20 PM
Subscribers

Details

Summary

This resolves ENG-5410.

The version of callServerEndpoint that resolveInvalidatedCookie gets passed is defined here. Instead of trying to dispatch a recovery attempt when it sees a session change that invalidates its cookie, this version of callServerEndpoint ignores the session change.

That solves the "double resolution" issue. It's also the right thing to use here... this overriden callServerEndpoint is used by the logIn action, and should be used by all other actions during the recovery attempt.

Depends on D9584

Test Plan

I used this patch to test. Before this diff, logs showed the first recovery attempt triggering a second one. After this diff, there was only one recovery attempt, and the initialNotificationsEncryptedMessage was resolved correctly.

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage