[native] Update iOS badge for rescinds
ClosedPublic
Actions

Authored by ashoat on Oct 25 2023, 9:12 AM.

Tags

None

Referenced Files

	F3383780: D9600.id32406.diff
	Thu, Nov 28, 5:42 PM

	Unknown Object (File)
	Mon, Nov 25, 1:24 AM

	Unknown Object (File)
	Sun, Nov 24, 11:50 PM

	Unknown Object (File)
	Oct 28 2024, 5:21 PM

	Unknown Object (File)
	Oct 4 2024, 2:00 AM

	Unknown Object (File)
	Oct 4 2024, 2:00 AM

	Unknown Object (File)
	Oct 4 2024, 2:00 AM

	Unknown Object (File)
	Oct 4 2024, 1:58 AM

Subscribers

Details

Reviewers

marcin
atul

Commits

rCOMM0e369a8ea87e: [native] Update iOS badge for rescinds

Summary

This resolves ENG-5452.

@marcin and I pair-programmed this solution together.

Test Plan

I tested both rescinds, badge-only notifs, and normal notifs in my local environment on the iOS simulator. They all worked correctly

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

ashoat created this revision.Oct 25 2023, 9:12 AM

Herald added subscribers: will, tomek. · View Herald TranscriptOct 25 2023, 9:12 AM

Harbormaster completed remote builds in B23494: Diff 32406.Oct 25 2023, 9:33 AM

ashoat requested review of this revision.Oct 25 2023, 9:33 AM

atul accepted this revision.Oct 25 2023, 9:35 AM

This revision is now accepted and ready to land.Oct 25 2023, 9:35 AM

Closed by commit rCOMM0e369a8ea87e: [native] Update iOS badge for rescinds (authored by ashoat). · Explain WhyOct 25 2023, 9:42 AM

This revision was automatically updated to reflect the committed changes.

ashoat added a commit: rCOMM0e369a8ea87e: [native] Update iOS badge for rescinds.

Revision Contents
Changeset List

Path

Size

native/

ios/

NotificationService/

NotificationService.mm

17 lines

Diff 32407

View Options

native/ios/NotificationService/NotificationService.mm

[native] Update iOS badge for rescindsClosedPublicActions