[keyserver] Always fetch the latest message for threads
ClosedPublic
Actions

Authored by michal on Jul 13 2023, 3:00 AM.

Details

Reviewers

kamil
inka
tomek

Commits

rCOMMe761a585c9dc: [keyserver] Always fetch the latest message for threads

Summary

ENG-891

We can efficiently fetch the latest message for each thread using the memberships.last_message column. Thanks to this we should get correct message preview and thread ordering in thread list.

NOTE: the no messages issue still can happen in the genesis chat because of ENG-4101

Test Plan

tested on mobile and web and checked if the messages previews are correctly displayed
checked that the only code paths that are changed by this diff is website-responders and login/register. Other methods that fetch messages are not affected
the query was tested on prod db and the time was similar, so performance shouldn't be an issue

Diff Detail

Repository

rCOMM Comm

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

michal created this revision.Jul 13 2023, 3:00 AM

Herald added a subscriber: ashoat. · View Herald TranscriptJul 13 2023, 3:00 AM

Harbormaster completed remote builds in B20915: Diff 28669.Jul 13 2023, 3:16 AM

michal requested review of this revision.Jul 13 2023, 3:16 AM

tomek accepted this revision.Jul 17 2023, 4:54 AM

tomek added inline comments.

keyserver/src/fetchers/message-fetchers.js
443 ↗	(On Diff #28669)	Do we know if this query uses indices?

This revision is now accepted and ready to land.Jul 17 2023, 4:54 AM

michal added inline comments.Jul 24 2023, 5:48 AM

keyserver/src/fetchers/message-fetchers.js
443 ↗	(On Diff #28669)	I've run `EXPLAIN` on the whole `fetchMessages` query and it looks like the indices don't changes (in case of the `messages` table it's still `thread`)