Page MenuHomePhabricator

[web] modify codegen script to generate files for identity_authenticated.proto
ClosedPublic

Authored by varun on Nov 8 2023, 10:20 PM.
Tags
None
Referenced Files
F3397671: D9793.id33030.diff
Sun, Dec 1, 6:54 PM
Unknown Object (File)
Fri, Nov 29, 1:00 PM
Unknown Object (File)
Wed, Nov 6, 7:56 PM
Unknown Object (File)
Wed, Nov 6, 7:56 PM
Unknown Object (File)
Oct 24 2024, 7:07 AM
Unknown Object (File)
Oct 24 2024, 5:12 AM
Unknown Object (File)
Oct 20 2024, 3:40 PM
Unknown Object (File)
Oct 18 2024, 4:34 AM
Subscribers

Details

Summary

we need the auth client available on web as well, so we should generate the relevant structs and client code

Depends on D9792

Test Plan

ran the script

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

varun requested review of this revision.Nov 8 2023, 10:38 PM

I don't love the naming here. The issue starts with the proto file names... "client" vs. "authenticated" isn't a clear dichotomy. The use of "client" in this file makes more sense, but adds further confusion.

This revision is now accepted and ready to land.Nov 9 2023, 4:17 AM

I don't love the naming here. The issue starts with the proto file names... "client" vs. "authenticated" isn't a clear dichotomy. The use of "client" in this file makes more sense, but adds further confusion.

i don't like the naming either. i'd prefer something like identity_unauthenticated.proto and identity_authenticated.proto. https://linear.app/comm/issue/ENG-5690/rename-proto-files-to-something-more-intuitive