Paths

Table of Contentst

[native][web] Fix keyserver store tranform error
ClosedPublic
Actions

Authored by inka on Sep 20 2023, 8:59 AM.

Details

Reviewers

michal
kamil

Commits

rCOMMaf77993c7b26: [native][web] Fix keyserver store tranform error

Summary

issue: https://linear.app/comm/issue/ENG-4930/keyserver-missing-from-keyserverstore
Please see this comment for detailed explantion of the solution: https://linear.app/comm/issue/ENG-4930/keyserver-missing-from-keyserverstore#comment-62fa00d1

Test Plan

Checked that after the migrations were added, the error does not appear.

Diff Detail

Repository

rCOMM Comm

Branch

inka/add_migration_for_transform

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

inka created this revision.Sep 20 2023, 8:59 AM

Herald added subscribers: tomek, ashoat. · View Herald TranscriptSep 20 2023, 8:59 AM

Harbormaster completed remote builds in B22760: Diff 31313.Sep 20 2023, 9:17 AM

inka requested review of this revision.Sep 20 2023, 9:17 AM

Is my understanding correct that there is still a toplevel connection field in redux state? Should we remove it inside of this migration?

This revision is now accepted and ready to land.Sep 22 2023, 8:13 AM

Remove connection from top level

Harbormaster failed remote builds in B24035: Diff 33119!Nov 13 2023, 6:44 AM

Rebase

Harbormaster completed remote builds in B24036: Diff 33120.Nov 13 2023, 7:09 AM

Closed by commit rCOMMaf77993c7b26: [native][web] Fix keyserver store tranform error (authored by inka). · Explain WhyNov 13 2023, 7:16 AM

This revision was automatically updated to reflect the committed changes.

inka added a commit: rCOMMaf77993c7b26: [native][web] Fix keyserver store tranform error.

Revision Contents
Changeset List

Path

Size

native/

redux/

persist.js

27 lines

web/

redux/

persist.js

24 lines

Diff 33120

View Options

native/redux/persist.js