Page MenuHomePhabricator
Differential D8425

Implement AESCryptoModule Java compatibility class
ClosedPublic
Actions

Authored by marcin on Jul 4 2023, 8:08 AM.
Tags
None
Referenced Files
F3573237: D8425.diff
Sat, Dec 28, 2:25 PM
Unknown Object (File)
Fri, Dec 27, 9:44 AM
Unknown Object (File)
Fri, Dec 27, 9:44 AM
Unknown Object (File)
Fri, Dec 27, 9:44 AM
Unknown Object (File)
Fri, Dec 27, 9:44 AM
Unknown Object (File)
Fri, Dec 27, 9:44 AM
Unknown Object (File)
Fri, Dec 27, 9:43 AM
Unknown Object (File)
Fri, Dec 27, 9:33 AM
View All Files
Subscribers
ashoat
tomek

Details

Reviewers
bartek
Commits
rCOMM14514aae1bd2: Implement AESCryptoModule Java compatibility class
Summary

This differential implements AES Crypto Module class that brings our AES crypto functionality tom pure native Android code.

Test Plan
  1. Apply those changes to CommNotificationsHandler: https://gist.github.com/marcinwasowicz/b427cf57b0d103470cd8570085954403 (literally copy paste)
  2. Send notification to running Android app.
  3. Examine logs in adb log cat

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

marcin created this revision.Jul 4 2023, 8:08 AM
Herald added subscribers: tomek, ashoat. · View Herald TranscriptJul 4 2023, 8:08 AM
marcin edited the test plan for this revision. (Show Details)Jul 4 2023, 8:10 AM
marcin added 1 blocking reviewer(s): bartek.
Harbormaster completed remote builds in B20717: Diff 28386.Jul 4 2023, 8:25 AM
marcin requested review of this revision.Jul 4 2023, 8:25 AM
bartek accepted this revision.Jul 4 2023, 12:12 PM

Looks good, just one nit

native/expo-modules/comm-expo-package/android/src/main/java/app/comm/android/aescrypto/AESCryptoModule.kt
112 ↗(On Diff #28386)

The same comment as for the Swift diff (D8424)

This revision is now accepted and ready to land.Jul 4 2023, 12:12 PM
marcin updated this revision to Diff 28404.Jul 5 2023, 3:44 AM

Add comments separating RN/Native code

Harbormaster completed remote builds in B20731: Diff 28404.Jul 5 2023, 4:01 AM
marcin added a child revision: D8566: Upload/download large notification payload from the keyserver/Android NSE if its size exceeds FCM limits.Jul 21 2023, 3:05 AM
marcin updated this revision to Diff 33266.Nov 15 2023, 6:58 AM

Rebase before landing

Harbormaster failed remote builds in B24152: Diff 33266!Nov 15 2023, 8:07 AM
Harbormaster completed remote builds in B24152: Diff 33266.Nov 15 2023, 8:56 AM
marcin updated this revision to Diff 33306.Nov 15 2023, 11:35 PM

Rebase before landing

Harbormaster completed remote builds in B24188: Diff 33306.Nov 15 2023, 11:54 PM
Closed by commit rCOMM14514aae1bd2: Implement AESCryptoModule Java compatibility class (authored by marcin). · Explain WhyNov 16 2023, 12:12 AM
This revision was automatically updated to reflect the committed changes.
marcin added a commit: rCOMM14514aae1bd2: Implement AESCryptoModule Java compatibility class.
michal mentioned this in D9938: [native] Refactor Android AESCryptoModule to use ByteBuffers.Nov 21 2023, 5:29 AM
Michal Gniadek <michal.gniadek@swmansion.com> mentioned this in rCOMM694000abcfa7: [native] Refactor Android AESCryptoModule to use ByteBuffers.Dec 1 2023, 6:19 AM

Revision Contents
Changeset List

PathSize
native/
expo-modules/
comm-expo-package/
android/
src/
main/
java/
app/
comm/
android/
aescrypto/
34 lines

Diff 33308

View Options

native/expo-modules/comm-expo-package/android/src/main/java/app/comm/android/aescrypto/AESCryptoModule.kt

Loading...