Page MenuHomePhabricator

[lib] Delete the old universalCommunityPermissions set
ClosedPublic

Authored by rohan on Nov 22 2023, 7:09 AM.
Tags
None
Referenced Files
F3513262: D9953.diff
Sat, Dec 21, 11:28 PM
Unknown Object (File)
Fri, Dec 20, 3:46 AM
Unknown Object (File)
Sun, Dec 15, 11:31 AM
Unknown Object (File)
Sun, Dec 15, 10:53 AM
Unknown Object (File)
Wed, Dec 11, 9:29 PM
Unknown Object (File)
Nov 7 2024, 9:19 PM
Unknown Object (File)
Nov 7 2024, 9:19 PM
Unknown Object (File)
Nov 7 2024, 9:19 PM
Subscribers

Details

Summary

Now that I'm ready to land the stack for fixing thread permissions, I can safely remove the old universalCommunityPermissions set since we now have a function that takes in a thread type and returns back a blob of universal community permissions accordingly.

Also took this time to quickly remove the unit tests that had previously hard-coded user-surfaced permissions for two reasons:

  • we now have a list defined in thread-permissions
  • we just do not need this unit test because now, since constructing member blobs for communities uses user-surfaced permissions, this unit test doesn't test anything of importance

Depends on D9945

Test Plan

Ran yarn workspace lib test and flow to make sure I covered all instances of the old universalCommunityPermissions

Diff Detail

Repository
rCOMM Comm
Branch
combined_branch
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

rohan retitled this revision from [lib] Depreciate the universalCommunityPermissions set to [lib] Delete the old universalCommunityPermissions set.Nov 22 2023, 7:12 AM
Harbormaster returned this revision to the author for changes because remote builds failed.Nov 22 2023, 7:22 AM
Harbormaster failed remote builds in B24342: Diff 33499!
rohan published this revision for review.Nov 22 2023, 8:41 AM
This revision is now accepted and ready to land.Nov 22 2023, 9:25 AM