[lib] update `currentAsOf` for SIWE auth
ClosedPublic
Actions

Authored by kamil on Nov 27 2023, 9:20 AM.

Details

Reviewers

inka
tomek
michal
ashoat

Commits

rCOMMef15fb4e402c: [lib] update `currentAsOf` for SIWE auth

Summary

Updating this to have correct type.

This partially caused ENG-5883.
We were returning 0 as the default value for currentAsOf in here: link.
This later caused a condition from D9965 truthy right after login.

Test Plan

Log currentAsOf
Log in using SIWE
Make sure it has correct type and value (previously it was number, not object).

Diff Detail

Repository

rCOMM Comm

Branch

fix-siwe-login

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

kamil created this revision.Nov 27 2023, 9:20 AM

kamil held this revision as a draft.

Herald added a subscriber: ashoat. · View Herald TranscriptNov 27 2023, 9:20 AM

kamil edited the summary of this revision. (Show Details)Nov 27 2023, 9:21 AM

kamil edited the summary of this revision. (Show Details)

kamil published this revision for review.Nov 27 2023, 9:29 AM

ashoat accepted this revision.Nov 27 2023, 9:29 AM

This revision is now accepted and ready to land.Nov 27 2023, 9:29 AM

This revision was landed with ongoing or failed builds.Nov 27 2023, 10:12 AM

Closed by commit rCOMMef15fb4e402c: [lib] update `currentAsOf` for SIWE auth (authored by kamil). · Explain Why

This revision was automatically updated to reflect the committed changes.

kamil added a commit: rCOMMef15fb4e402c: [lib] update `currentAsOf` for SIWE auth.

Harbormaster completed remote builds in B24531: Diff 33749.Nov 27 2023, 11:19 AM

ashoat mentioned this in D10190: [lib] Fix updatesCurrentAsOf returned from siweAuth.Dec 5 2023, 7:20 PM

Revision Contents
Changeset List

Path

Size

lib/

actions/

siwe-actions.js

2 lines

Diff 33749

View Options

lib/actions/siwe-actions.js

[lib] update `currentAsOf` for SIWE authClosedPublicActions