Page MenuHomePhabricator
Differential D10068

[lib] Re-introduce `RoleInfo` (`[Legacy/MinimallyEncoded]RoleInfo`)
ClosedPublic
Actions

Authored by atul on Nov 28 2023, 7:15 AM.
Tags
None
Referenced Files
F3385735: D10068.id34005.diff
Fri, Nov 29, 2:03 AM
F3385726: D10068.id33942.diff
Fri, Nov 29, 2:02 AM
Unknown Object (File)
Mon, Nov 25, 1:28 PM
Unknown Object (File)
Mon, Nov 25, 11:44 AM
Unknown Object (File)
Sat, Nov 9, 3:59 AM
Unknown Object (File)
Fri, Nov 8, 10:55 AM
Unknown Object (File)
Fri, Nov 8, 10:43 AM
Unknown Object (File)
Fri, Nov 8, 10:32 AM
View All 66 Files
Subscribers
None

Details

Reviewers
ashoat
ginsu
tomek
rohan
Commits
rCOMMc2810872327a: [lib] Re-introduce `RoleInfo` (`[Legacy/MinimallyEncoded]RoleInfo`)
Summary

Replace usages of LegacyRoleInfo | MinimallyEncodedRoleInfo with re-introduced RoleInfo.

This doesn't make much of a difference with RoleInfo since there are just a few occurrences, but has more of an impact on eg MinimallyEncodedThreadInfo

Depends on D10066

Test Plan

flow/CI/etc.

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

atul updated this revision to Diff 33944.Nov 28 2023, 7:15 AM
atul created this revision.

rebase

Harbormaster failed remote builds in B24566: Diff 33942!Nov 28 2023, 7:31 AM
atul added a child revision: D10071: [lib] `MemberInfo` -> `LegacyMemberInfo`.Nov 28 2023, 7:43 AM
atul published this revision for review.Nov 28 2023, 7:43 AM
Harbormaster completed remote builds in B24568: Diff 33944.Nov 28 2023, 8:20 AM
atul mentioned this in D10074: [lib] Re-introduce `RelativeMemberInfo` (`[Legacy/MinimallyEncoded]RelativeMemberInfo`).Nov 28 2023, 9:48 AM
ashoat accepted this revision.Nov 28 2023, 12:54 PM
This revision is now accepted and ready to land.Nov 28 2023, 12:54 PM
atul mentioned this in D10078: [lib] Reintroduce `RawThreadInfo` (`[Legacy/MinimallyEncoded]RawThreadInfo`).Nov 28 2023, 1:36 PM
Closed by commit rCOMMc2810872327a: [lib] Re-introduce `RoleInfo` (`[Legacy/MinimallyEncoded]RoleInfo`) (authored by atul). · Explain WhyNov 29 2023, 3:20 PM
This revision was automatically updated to reflect the committed changes.
atul added a commit: rCOMMc2810872327a: [lib] Re-introduce `RoleInfo` (`[Legacy/MinimallyEncoded]RoleInfo`).
atul mentioned this in rCOMM585efacdc7a5: [lib] Re-introduce `RelativeMemberInfo` (`….
atul mentioned this in rCOMMbfd6ef196960: [lib] Reintroduce `RawThreadInfo` (`[Legacy/MinimallyEncoded]RawThreadInfo`).
atul mentioned this in D10095: [lib] `ThreadInfo` -> `LegacyThreadInfo`.Nov 30 2023, 8:31 AM

Revision Contents
Changeset List

PathSize
lib/
shared/
7 lines
types/
7 lines
utils/
10 lines

Diff 34005

View Options

lib/shared/thread-utils.js

Loading...
View Options

lib/types/thread-types.js

Loading...
View Options

lib/utils/role-utils.js

Loading...