Page MenuHomePhabricator

[native] Use consistent panel colors in QR code screens
ClosedPublic

Authored by rohan on Nov 30 2023, 8:29 AM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Jan 11, 1:34 PM
Unknown Object (File)
Sun, Jan 5, 3:26 PM
Unknown Object (File)
Sun, Jan 5, 6:40 AM
Unknown Object (File)
Thu, Dec 26, 7:04 PM
Unknown Object (File)
Dec 19 2024, 2:48 AM
Unknown Object (File)
Dec 19 2024, 2:48 AM
Unknown Object (File)
Dec 19 2024, 2:48 AM
Unknown Object (File)
Dec 19 2024, 2:48 AM
Subscribers

Details

Summary

All of the components in qr-code-screen.react.js use a color from the panel color family, but the background in qr-code-sign-in-navigator.js use a color from the modal family. This diff just swaps the color out to instead remain consistent and use a color from the panel family.

This should have no impact visually because panelBackground is the same as modalBackground (designSystemColors.shadesBlack95)

Test Plan

Confirmed that there is no visual change

Diff Detail

Repository
rCOMM Comm
Branch
colors
Lint
No Lint Coverage
Unit
No Test Coverage