Paths

Table of Contentst

[web] catch error while processing store operations
ClosedPublic
Actions

Authored by kamil on Dec 4 2023, 6:31 AM.

Details

Reviewers

tomek
michal

Commits

rCOMMa66dc12f4518: [web] catch error while processing store operations

Summary

This is an improvement to ENG-5910.

Previously only on the worker console was some indication that processing store ops failed.
Adding an alert for staff users to know if ENG-5910 is caused by this.

Also, matching native, where when there are ops failures we close the app and then delete the database. Here we delete the database and reload app to show login screen for user.

Test Plan

Make operation with updating draft to throw and see video:

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

kamil created this revision.Dec 4 2023, 6:31 AM

kamil held this revision as a draft.

Herald added a subscriber: ashoat. · View Herald TranscriptDec 4 2023, 6:31 AM

kamil edited the summary of this revision. (Show Details)Dec 4 2023, 6:33 AM

kamil edited the test plan for this revision. (Show Details)

kamil published this revision for review.Dec 4 2023, 7:03 AM

Harbormaster completed remote builds in B24725: Diff 34182.Dec 4 2023, 7:04 AM

tomek accepted this revision.Dec 4 2023, 8:04 AM

tomek added inline comments.

web/database/utils/store.js
85 ↗	(On Diff #34182)	It might be a good idea to hide this behind `isStaff` check

This revision is now accepted and ready to land.Dec 4 2023, 8:04 AM

kamil added inline comments.Dec 5 2023, 3:11 AM

web/database/utils/store.js
85 ↗	(On Diff #34182)	`canUseDatabase` is result of `isStaff` check

Closed by commit rCOMMa66dc12f4518: [web] catch error while processing store operations (authored by kamil). · Explain WhyDec 5 2023, 3:13 AM

This revision was automatically updated to reflect the committed changes.

kamil added a commit: rCOMMa66dc12f4518: [web] catch error while processing store operations.

This diff is not very useful because the logs won't appear for the crash. These logs appear in the session preceding the crash, which causes the crash. But nobody will know to check the logs, because they won't see any issues. After refreshing, they will see issues, but there will be nothing in the logs.

EDIT

@kamil pointed out that there is an alert here, that would likely catch the user's attention

Revision Contents
Changeset List

Path

Size

web/

database/

utils/

store.js

29 lines

worker/

process-operations.js

86 lines

Diff 34268

View Options

web/database/utils/store.js