i meant to make this a draft diff.. i guess i can't undo that now. @bartek i'm having trouble reading from my native/facts/identity_service_config.json file because we build the native rust library and then Xcode links it in some sort of sandbox where the file isn't present. any thoughts on how to proceed here? i can just set the SOCKET_ADDR const in build.rs similar to how we set CODE_VERSION but wondering if there's a cleaner way...

In D10201#296286, @varun wrote:

In D10201#296285, @varun wrote:

i meant to make this a draft diff.. i guess i can't undo that now. @bartek i'm having trouble reading from my native/facts/identity_service_config.json file because we build the native rust library and then Xcode links it in some sort of sandbox where the file isn't present. any thoughts on how to proceed here? i can just set the SOCKET_ADDR const in build.rs similar to how we set CODE_VERSION but wondering if there's a cleaner way...

actually i think build.rs is the best solution

I'm confused – what is actually being configured in build.rs here? Shouldn't this diff be using get_config introduced in D10148? Is there something "broken" with D10148?

In D10201#296313, @ashoat wrote:

In D10201#296286, @varun wrote:

In D10201#296285, @varun wrote:

i meant to make this a draft diff.. i guess i can't undo that now. @bartek i'm having trouble reading from my native/facts/identity_service_config.json file because we build the native rust library and then Xcode links it in some sort of sandbox where the file isn't present. any thoughts on how to proceed here? i can just set the SOCKET_ADDR const in build.rs similar to how we set CODE_VERSION but wondering if there's a cleaner way...

actually i think build.rs is the best solution

I'm confused – what is actually being configured in build.rs here? Shouldn't this diff be using get_config introduced in D10148? Is there something "broken" with D10148?

That diff is for keyserver only. Native apps don't support reading env vars in runtime - their runtime is smartphone or simulator, they should be separated from host machine. Also reading file at runtime on mobile app means searching for it on the device's disk (or emulator-specific directories).
React-Native/Expo provide hacks to expose env vars to JS via Metro bundler (I used this in natDevHostname) but for Rust the values need to be accessible in native code.

build.rs will work but it's cumbersome to rebuild native app just to change identity endpoint. On the other hand, passing values JS -> Rust sounds like lots of additional work (or am I wrong?). Wondering if there's a better solution.

Thanks for clarifying, @bartek! I definitely got myself confused there. We don't use getCommConfig in JS on native currently either, so I don't think there's any expectation to use get_config in Rust on native.

I share your concerns that build.rs is an unideal place to put this config, but I'm not sure of any alternatives. Don't want to block this diff if there are no obvious alternatives.