[native] native_rust_library debug builds
ClosedPublic
Actions

Authored by varun on Dec 4 2023, 10:03 PM.

Details

Reviewers

bartek
ashoat

Commits

rCOMM9d57f4c1ed32: [native] native_rust_library debug builds

Summary

we don't need to do release builds of the rust library when we're just doing a debug build of the iOS app

Test Plan

built the app for simulator and did archive builds a couple times in different orders, confirmed everything succeeded. checked the target folder to make sure we aren't doing release builds for debug builds of the app anymore.

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

varun created this revision.Dec 4 2023, 10:03 PM

Herald added a subscriber: tomek. · View Herald TranscriptDec 4 2023, 10:03 PM

varun added a child revision: D10187: [native] use build configuration to set socket addr.Dec 4 2023, 10:05 PM

varun added inline comments.Dec 4 2023, 10:13 PM

scripts/build-rust-native-library.sh
40 ↗	(On Diff #34244)	$CONFIGURATION is set by Xcode

Harbormaster completed remote builds in B24781: Diff 34244.Dec 4 2023, 10:33 PM

varun requested review of this revision.Dec 4 2023, 10:33 PM

ashoat accepted this revision.Dec 5 2023, 5:59 AM

ashoat added inline comments.

scripts/build-rust-native-library.sh
41 ↗	(On Diff #34244)	Please use two-space indents

This revision is now accepted and ready to land.Dec 5 2023, 5:59 AM

Closed by commit rCOMM9d57f4c1ed32: [native] native_rust_library debug builds (authored by varun). · Explain WhyDec 7 2023, 10:02 PM

This revision was automatically updated to reflect the committed changes.

varun added a commit: rCOMM9d57f4c1ed32: [native] native_rust_library debug builds.

Revision Contents
Changeset List

Path

Size

native/

ios/

Comm.xcodeproj/

project.pbxproj

4 lines

scripts/

build-rust-native-library.sh

7 lines

Diff 34406

View Options

native/ios/Comm.xcodeproj/project.pbxproj