We need to specify the platform key in the docker compose file so that we build images for the correct platform for the aws ECS.
Details
Details
docker compose build, check if the image was built
Diff Detail
Diff Detail
- Repository
- rCOMM Comm
- Lint
Lint Not Applicable - Unit
Tests Not Applicable
Event Timeline
Comment Actions
docker compose build, check if the image was built
To make sure the platform is correct, you can use the following command
docker inspect commapp/electron-update-server:2.0 -f "{{.Os}}/{{.Architecture}}"| services/electron-update-server/docker-compose.yml | ||
|---|---|---|
| 4 ↗ | (On Diff #34285) | I've already published 2.0. Should we bump this to 3.0? |
| services/electron-update-server/docker-compose.yml | ||
|---|---|---|
| 4 ↗ | (On Diff #34285) | Ah – seeing in the doc that bumping the version number is meant to happen after testing on staging That order seems a little strange to me though, since after publishing to Docker Hub, this step is kind of impossible to reverse, right? |
| services/electron-update-server/docker-compose.yml | ||
|---|---|---|
| 4 ↗ | (On Diff #34285) | Unlike npm, you can publish again with the same tag (overwrite the image). You can also delete image with specific tag on DockerHub (it is safe if it wasn't ever pulled).
IMO this applies more to other services than to this one - I assume that when CI will be auto-deploying staging services, it should use some constant tag like "staging" - bumping version tag with every commit doesn't make sense Generally, the tag/version policy depends on us, it is supposed to be helpful, not to limit. |
| 4 ↗ | (On Diff #34285) |
I'd go with overwriting 2.0 if it wasn't ever used |
Comment Actions
docker inspect commapp/electron-update-server:2.0 -f "{{.Os}}/{{.Architecture}}"
Tested, it returned linux/amd64 as expected.