Page MenuHomePhabricator

[lib] Memoize userinfos in usePotentialMemberItems
ClosedPublic

Authored by rohan on Dec 19 2023, 8:47 PM.
Tags
None
Referenced Files
F1791690: D10409.id34876.diff
Sun, May 19, 12:30 PM
F1791117: D10409.id.diff
Sun, May 19, 10:25 AM
Unknown Object (File)
Fri, May 10, 3:03 PM
Unknown Object (File)
Wed, May 8, 1:29 PM
Unknown Object (File)
Apr 14 2024, 2:56 PM
Unknown Object (File)
Apr 14 2024, 2:56 PM
Unknown Object (File)
Apr 14 2024, 2:56 PM
Unknown Object (File)
Apr 14 2024, 2:56 PM
Subscribers

Details

Summary

This addresses the urgent issue outlined in ENG-6139. I should've memoized the userInfos object.

Test Plan

Since usePotentialMemberItems is used in both chat-thread-composer.react.js and add-members-modal.react.js (both also mentioned in the original bug report), I made sure that those both no longer completely freeze/crash.

Diff Detail

Repository
rCOMM Comm
Branch
fix
Lint
No Lint Coverage
Unit
No Test Coverage