Differential D10548
[web] factor out pinned messages banner into its own component Authored by ginsu on Jan 5 2024, 12:09 AM. Tags None Referenced Files
Details We will be using the thread top bar component as the panel header for the message list panel item. In order to accomplish this we will need to decouple the pinned messages banner from the top bar. To make the move a bit easier/more organized, I took a second to make the pinned messages banner into its own component. Additionally, I snuck in some color changes that have the pinned messages banner utilize the new color design system. flow and confirmed the pinned messages banner still works as expected. Also please see the screenshots below: dark:  light: 
Diff Detail
Event TimelineComment Actions Personally think it's fine you snuck the color name change in this diff, but in the future we should definitely make a note of that in the Summary section and annotate the change in the diff. Comment Actions
My bad for not calling this out earlier. I was trying to "take out two birds with one diff" in regards with also updating the colors in the pinned messages banner to utilize the new color design system. I'll be more careful about this in the future, and will make sure that these types are changes are super clear in the summary + annotated before the first pass of review. I have updated the test plan to include screenshots of the pinned messages banner in both dark + light mode |