Details
Details
- Reviewers
kamil michal - Commits
- rCOMM788388c640fe: [services] Use comm-lib aws in Tunnelbroker
Tunnelbroker compiles.
Diff Detail
Diff Detail
- Repository
- rCOMM Comm
- Lint
No Lint Coverage - Unit
No Test Coverage
Event Timeline
| services/tunnelbroker/Cargo.toml | ||
|---|---|---|
| 23 ↗ | (On Diff #34985) | This dep turns out to be unused, see https://phab.comm.dev/D10392#inline-63616 |
Comment Actions
Nice!
| services/tunnelbroker/src/database/message.rs | ||
|---|---|---|
| 25 ↗ | (On Diff #34985) | Could we implement something like: impl From<DBItemError> for MessageErrors {
fn from(self) -> MessageErrors {
// possibly also `error!` self so we don't lose the exact error? Not sure
MessageErrors::SerializationError
}
}and remove the map_err? |
| services/tunnelbroker/src/database/message.rs | ||
|---|---|---|
| 25 ↗ | (On Diff #34985) | The purpose of this diff was to only replace DDB raw types with comm-lib counterparts, without further refactors, but this suggestion makes so much sense so I'll do this |