Page MenuHomePhabricator
Differential D10563

[web] fix secondary header shadow color
ClosedPublic
Actions

Authored by ginsu on Jan 7 2024, 11:49 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Sep 8, 7:16 AM
Unknown Object (File)
Aug 27 2024, 5:00 AM
Unknown Object (File)
Aug 13 2024, 9:47 AM
Unknown Object (File)
Aug 13 2024, 9:47 AM
Unknown Object (File)
Aug 13 2024, 9:47 AM
Unknown Object (File)
Aug 13 2024, 9:47 AM
Unknown Object (File)
Aug 13 2024, 9:46 AM
Unknown Object (File)
Jul 6 2024, 6:51 AM
View All 44 Files
Subscribers
ashoat
tomek

Details

Reviewers
atul
inka
Commits
rCOMM57b810d8e994: [web] fix secondary header shadow color
Summary

In the figma, I noticed that for secondary panel items (the panel items with a darker shade) the shadow color should have an opacity of 25% rather than 35%. This diff introduces that new variant and addresses that fix

Test Plan

flow + please see the screenshot below

Screenshot 2024-01-08 at 2.53.19 AM.png (236×2 px, 38 KB)

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

ginsu created this revision.Jan 7 2024, 11:49 PM
Herald added subscribers: tomek, ashoat. · View Herald TranscriptJan 7 2024, 11:49 PM
ginsu edited the summary of this revision. (Show Details)Jan 7 2024, 11:55 PM
ginsu edited the test plan for this revision. (Show Details)
ginsu added reviewers: atul, inka.
ginsu attached a referenced file: F1043162: Screenshot 2024-01-08 at 2.53.19 AM.png. (Show Details)
ginsu added inline comments.
web/theme.css
375

Added this variable to the list in this linear task:

https://linear.app/comm/issue/ENG-6351/confirm-panel-light-mode-colors

Harbormaster returned this revision to the author for changes because remote builds failed.Jan 8 2024, 12:17 AM
Harbormaster failed remote builds in B25571: Diff 35338!
ginsu requested review of this revision.Jan 8 2024, 12:19 AM

will make sure ci passes before landing

atul accepted this revision.Jan 8 2024, 2:51 PM
This revision is now accepted and ready to land.Jan 8 2024, 2:51 PM
ginsu updated this revision to Diff 35548.Jan 11 2024, 9:28 AM

rebase to make sure ci passes before landing

Harbormaster completed remote builds in B25707: Diff 35548.Jan 11 2024, 9:52 AM
Closed by commit rCOMM57b810d8e994: [web] fix secondary header shadow color (authored by ginsu). · Explain WhyJan 11 2024, 10:33 AM
This revision was automatically updated to reflect the committed changes.
ginsu added a commit: rCOMM57b810d8e994: [web] fix secondary header shadow color.

Revision Contents
Changeset List

PathSize
web/
components/
5 lines
7 lines
4 lines

Diff 35338

View Options

web/components/panel.css

Loading...
View Options

web/components/panel.react.js

Loading...
View Options

web/theme.css

Loading...