[lib] Separate out keyserver utils in action-utils.js into a separate file
ClosedPublic
Actions

Authored by ashoat on Jan 8 2024, 11:40 AM.

Details

Reviewers

inka
varun
tomek

Commits

rCOMMe10843579a7f: [lib] Separate out keyserver utils in action-utils.js into a separate file

Summary

action-utils.js is getting to be quite large, so I'm factoring these out.

Depends on D10578

Test Plan

Flow

Diff Detail

Repository

rCOMM Comm

Branch

ashoat/ident2

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

ashoat created this revision.Jan 8 2024, 11:40 AM

Note – this was a pure move. None of the actual code was changed

Harbormaster failed remote builds in B25614: Diff 35409!Jan 8 2024, 12:11 PM

We have a keyserver-utils.js file in lib/shared/. Should we merge them?
I'm also not sure about ksconn folder name, I can't tell what exactly it is supposed to mean even though I know the contents, so I feel like it may be even more confusing for other people on the team

We have a keyserver-utils.js file in lib/shared/. Should we merge them?

This file just contains the utilities you created for useKeyserverCall stuff... I think it makes sense as its own logical unit. Maybe I'll just rename the file to reduce the ambiguity?

In D10579#306097, @inka wrote:

I'm also not sure about ksconn folder name, I can't tell what exactly it is supposed to mean even though I know the contents, so I feel like it may be even more confusing for other people on the team

Open to any other suggested name... I wasn't sure about ksconn either, was just thinking of "keyserver connection". How about keyserver-conn?