Page MenuHomePhabricator

[lib] Separate out keyserver utils in action-utils.js into a separate file
ClosedPublic

Authored by ashoat on Jan 8 2024, 11:40 AM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Nov 27, 6:06 AM
Unknown Object (File)
Wed, Nov 27, 2:54 AM
Unknown Object (File)
Nov 6 2024, 9:34 AM
Unknown Object (File)
Oct 17 2024, 3:03 PM
Unknown Object (File)
Oct 17 2024, 3:03 PM
Unknown Object (File)
Oct 17 2024, 3:03 PM
Unknown Object (File)
Oct 17 2024, 3:02 PM
Unknown Object (File)
Oct 17 2024, 3:02 PM
Subscribers
None

Details

Summary

action-utils.js is getting to be quite large, so I'm factoring these out.

Depends on D10578

Test Plan

Flow

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

ashoat published this revision for review.Jan 8 2024, 11:48 AM

Note – this was a pure move. None of the actual code was changed

We have a keyserver-utils.js file in lib/shared/. Should we merge them?
I'm also not sure about ksconn folder name, I can't tell what exactly it is supposed to mean even though I know the contents, so I feel like it may be even more confusing for other people on the team

We have a keyserver-utils.js file in lib/shared/. Should we merge them?

This file just contains the utilities you created for useKeyserverCall stuff... I think it makes sense as its own logical unit. Maybe I'll just rename the file to reduce the ambiguity?

In D10579#306097, @inka wrote:

I'm also not sure about ksconn folder name, I can't tell what exactly it is supposed to mean even though I know the contents, so I feel like it may be even more confusing for other people on the team

Open to any other suggested name... I wasn't sure about ksconn either, was just thinking of "keyserver connection". How about keyserver-conn?

This revision is now accepted and ready to land.Jan 10 2024, 1:06 AM