Paths

Table of Contentst

Differential D10593

[lib][native][web] Move DispatchActionPromise to a separate file
ClosedPublic
Actions

Authored by ashoat on Jan 10 2024, 5:49 AM.

Tags

None

Referenced Files

	F3376950: D10593.diff
	Wed, Nov 27, 3:01 AM

	Unknown Object (File)
	Sat, Nov 23, 1:48 PM

	Unknown Object (File)
	Sat, Nov 23, 12:09 PM

	Unknown Object (File)
	Mon, Nov 18, 8:45 AM

	Unknown Object (File)
	Fri, Nov 8, 7:25 AM

	Unknown Object (File)
	Wed, Nov 6, 9:17 AM

	Unknown Object (File)
	Oct 17 2024, 3:20 PM

	Unknown Object (File)
	Oct 17 2024, 3:20 PM

View All 87 Files

Subscribers

None

Details

Reviewers

inka
varun
tomek

Commits

rCOMM61ebc288f0bf: [lib][native][web] Move DispatchActionPromise to a separate file

Summary

As part of the continued separation of action-utils.js into multiple files, in this diff I move DispatchActionPromise and friends to lib/utils/redux-promise-utils.js. I decided not to put the file into lib/keyserver-conn because it's not really keyserver-specific.

Test Plan

Flow

Diff Detail

Repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

ashoat created this revision.Jan 10 2024, 5:49 AM

ashoat added inline comments.Jan 10 2024, 5:51 AM

lib/utils/action-utils.js
137–140 ↗	(On Diff #35482)	This diff is a pure move, with the exception of the exported type `DispatchFunctions`. This type is not used anywhere in the codebase, so I decided to simply delete it instead of moving

Harbormaster completed remote builds in B25659: Diff 35482.Jan 10 2024, 6:13 AM

ashoat requested review of this revision.Jan 10 2024, 6:13 AM

ashoat added a child revision: D10596: [lib] Fix typo in policy-acknowledge-utlis.js filename.Jan 10 2024, 12:22 PM

tomek accepted this revision.Jan 11 2024, 12:45 AM

inka accepted this revision.Jan 11 2024, 2:11 AM

This revision is now accepted and ready to land.Jan 11 2024, 2:11 AM

Closed by commit rCOMM61ebc288f0bf: [lib][native][web] Move DispatchActionPromise to a separate file (authored by ashoat). · Explain WhyJan 11 2024, 8:17 AM

This revision was automatically updated to reflect the committed changes.

ashoat added a commit: rCOMM61ebc288f0bf: [lib][native][web] Move DispatchActionPromise to a separate file.

Large Diff

This large diff affects 102 files. Files without inline comments have been collapsed. Expand All Files

Revision Contents
Changeset List

Path

Size

lib/

components/

base-edit-thread-avatar-provider.react.js

2 lines

edit-user-avatar-provider.react.js

6 lines

keyserver-connection-handler.js

2 lines

hooks/

child-threads.js

2 lines

invite-links.js

2 lines

promote-sidebar.react.js

2 lines

relationship-prompt.js

6 lines

toggle-unread-status.js

2 lines

shared/

crypto-utils.js

6 lines

edit-messages-utils.js

2 lines

keyserver-utils.js

2 lines

messages/

text-message-spec.js

2 lines

search-utils.js

6 lines

thread-utils.js

10 lines

socket/

activity-handler.react.js

2 lines

calendar-query-handler.react.js

2 lines

report-handler.react.js

2 lines

socket.react.js

2 lines

utils/

action-utils.js

111 lines

policy-acknowledge-utlis.js

2 lines

redux-promise-utils.js

111 lines

native/

account/

log-in-panel.react.js

2 lines

register-panel.react.js

4 lines

registration/

connect-ethereum.react.js

6 lines

registration-server-call.js

6 lines

username-selection.react.js

6 lines

6 lines

siwe-panel.react.js

2 lines

terms-and-privacy-modal.react.js

6 lines

calendar/

calendar.react.js

8 lines

8 lines

chat/

chat-input-bar.react.js

4 lines

compose-subchannel.react.js

2 lines

message-list.react.js

4 lines

message-report-utils.js

2 lines

reaction-message-utils.js

2 lines

settings/

add-users-modal.react.js

2 lines

color-selector-modal.react.js

6 lines

delete-thread.react.js

4 lines

thread-settings-description.react.js

4 lines

thread-settings-edit-relationship.react.js

6 lines

thread-settings-home-notifs.react.js

6 lines

thread-settings-leave-thread.react.js

4 lines

thread-settings-member-tooltip-modal.react.js

2 lines

thread-settings-name.react.js

4 lines

thread-settings-push-notifs.react.js

6 lines

toggle-pin-modal.react.js

2 lines

community-creation/

community-configuration.react.js

2 lines

community-creation-members.react.js

2 lines

components/

version-supported.react.js

2 lines

4 lines

input/

input-state-container.react.js

10 lines

navigation/

community-drawer-content.react.js

2 lines

deep-links-context-provider.react.js

6 lines

invite-link-modal.react.js

2 lines

profile/

default-notifications-preferences.react.js

4 lines

delete-account.react.js

2 lines

edit-password.react.js

4 lines

profile-screen.react.js

4 lines

relationship-list-item.react.js

6 lines

relationship-list.react.js

6 lines

user-relationship-tooltip-modal.react.js

6 lines

push/

push-handler.react.js

8 lines

roles/

change-roles-header-right-button.react.js

2 lines

create-roles-header-right-button.react.js

2 lines

role-utils.react.js

2 lines

socket.react.js

6 lines

web/

account/

siwe-login-form.react.js

6 lines

traditional-login-form.react.js

2 lines

calendar/

calendar.react.js

8 lines

8 lines

chat/

chat-input-bar.react.js

4 lines

chat-message-list.react.js

4 lines

reaction-message-utils.js

2 lines

thread-menu.react.js

2 lines

input/

input-state-container.react.js

10 lines

invite-links/

accept-invite-modal.react.js

2 lines

invite-link-handler.react.js

6 lines

invite-links-refresher.react.js

2 lines

modals/

chat/

pinned-messages-modal.react.js

2 lines

toggle-pin-modal.react.js

2 lines

history/

history-entry.react.js

6 lines

history-modal.react.js

6 lines

terms-and-privacy-modal.react.js

6 lines

threads/

create/

compose-subchannel-modal.react.js

2 lines

members/

add-members-modal.react.js

2 lines

change-member-role-modal.react.js

2 lines

member.react.js

2 lines

notifications/

notifications-modal.react.js

2 lines

settings/

thread-settings-delete-tab.react.js

2 lines

thread-settings-general-tab.react.js

2 lines

thread-settings-privacy-tab.react.js

2 lines

thread-settings-relationship-button.react.js

6 lines

push-notif/

push-notifs-handler.js

2 lines

roles/

create-roles-modal.react.js

2 lines

delete-role-modal.react.js

2 lines

settings/

account-delete-modal.react.js

2 lines

account-settings.react.js

2 lines

password-change-modal.js

6 lines

relationship/

add-users-list.react.js

6 lines

sidebar/

community-creation/

community-creation-modal.react.js

2 lines

socket.react.js

2 lines

Diff 35537

lib/components/base-edit-thread-avatar-provider.react.js

lib/components/edit-user-avatar-provider.react.js

lib/components/keyserver-connection-handler.js

lib/hooks/child-threads.js

lib/hooks/invite-links.js

lib/hooks/promote-sidebar.react.js

lib/hooks/relationship-prompt.js

lib/hooks/toggle-unread-status.js

lib/shared/crypto-utils.js

lib/shared/edit-messages-utils.js

lib/shared/keyserver-utils.js

lib/shared/messages/text-message-spec.js

lib/shared/search-utils.js

lib/shared/thread-utils.js

lib/socket/activity-handler.react.js

lib/socket/calendar-query-handler.react.js

lib/socket/report-handler.react.js

lib/socket/socket.react.js

lib/utils/action-utils.js

lib/utils/policy-acknowledge-utlis.js

lib/utils/redux-promise-utils.js

native/account/log-in-panel.react.js

native/account/register-panel.react.js

native/account/registration/connect-ethereum.react.js

native/account/registration/registration-server-call.js

native/account/registration/username-selection.react.js

native/account/siwe-hooks.js

native/account/siwe-panel.react.js

native/account/terms-and-privacy-modal.react.js

native/calendar/calendar.react.js

native/calendar/entry.react.js

native/chat/chat-input-bar.react.js

native/chat/compose-subchannel.react.js

native/chat/message-list.react.js

native/chat/message-report-utils.js

native/chat/reaction-message-utils.js

native/chat/settings/add-users-modal.react.js

native/chat/settings/color-selector-modal.react.js

native/chat/settings/delete-thread.react.js

native/chat/settings/thread-settings-description.react.js

native/chat/settings/thread-settings-edit-relationship.react.js

native/chat/settings/thread-settings-home-notifs.react.js

native/chat/settings/thread-settings-leave-thread.react.js

native/chat/settings/thread-settings-member-tooltip-modal.react.js

native/chat/settings/thread-settings-name.react.js

native/chat/settings/thread-settings-push-notifs.react.js

native/chat/toggle-pin-modal.react.js

native/community-creation/community-configuration.react.js

native/community-creation/community-creation-members.react.js

native/components/version-supported.react.js

native/crash.react.js

native/input/input-state-container.react.js

native/navigation/community-drawer-content.react.js

native/navigation/deep-links-context-provider.react.js

native/navigation/invite-link-modal.react.js

native/profile/default-notifications-preferences.react.js

native/profile/delete-account.react.js

native/profile/edit-password.react.js

native/profile/profile-screen.react.js

native/profile/relationship-list-item.react.js

native/profile/relationship-list.react.js

native/profile/user-relationship-tooltip-modal.react.js

native/push/push-handler.react.js

native/roles/change-roles-header-right-button.react.js

native/roles/create-roles-header-right-button.react.js

native/roles/role-utils.react.js

native/socket.react.js

web/account/siwe-login-form.react.js

web/account/traditional-login-form.react.js

web/calendar/calendar.react.js

web/calendar/entry.react.js

web/chat/chat-input-bar.react.js

web/chat/chat-message-list.react.js

web/chat/reaction-message-utils.js

web/chat/thread-menu.react.js

web/input/input-state-container.react.js

web/invite-links/accept-invite-modal.react.js

web/invite-links/invite-link-handler.react.js

web/invite-links/invite-links-refresher.react.js

web/modals/chat/pinned-messages-modal.react.js

web/modals/chat/toggle-pin-modal.react.js

web/modals/history/history-entry.react.js

web/modals/history/history-modal.react.js

web/modals/terms-and-privacy-modal.react.js

web/modals/threads/create/compose-subchannel-modal.react.js

web/modals/threads/members/add-members-modal.react.js

web/modals/threads/members/change-member-role-modal.react.js

web/modals/threads/members/member.react.js

web/modals/threads/notifications/notifications-modal.react.js

web/modals/threads/settings/thread-settings-delete-tab.react.js

web/modals/threads/settings/thread-settings-general-tab.react.js

web/modals/threads/settings/thread-settings-privacy-tab.react.js

web/modals/threads/settings/thread-settings-relationship-button.react.js

web/push-notif/push-notifs-handler.js

web/roles/create-roles-modal.react.js

web/roles/delete-role-modal.react.js

web/settings/account-delete-modal.react.js

web/settings/account-settings.react.js

web/settings/password-change-modal.js

web/settings/relationship/add-users-list.react.js

web/sidebar/community-creation/community-creation-modal.react.js

web/socket.react.js